[GitHub] [spark] tgravescs commented on pull request #41173: [SPARK-43510][YARN] Fix YarnAllocator internal state when adding running executor after processing completed containers

["tgravescs (via GitHub)" <gi...@apache.org>]

tgravescs commented on PR #41173:
URL: https://github.com/apache/spark/pull/41173#issuecomment-1553426997

   Have you only seen this once?  Do you have any repro case or tried to make a test to simulate?
   
   I'm a bit unclear exactly how this happens, from taking a quick look, both those functions that add and remove are synchronized.  Am I missing how these can be called and actually run at the same time?
   
   You are essentially implying that the completed container is called after we launched the executor but before we could add it containerIdToExecutorIdAndResourceProfileId.  I do see from your logs, all that happened with the same second.  Maybe not crucial but do you know why that container was completed so quickly?
   
   As from my comment, I don't see you cleaning up this new datastructure, I would much rather look at either preventing this from running or perhaps having another launching state that you would check before removing.  But would like to understand above first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org