You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/25 06:40:30 UTC
[GitHub] [apisix-dashboard] LiteSun opened a new issue #1512: Plugin template configuration
LiteSun opened a new issue #1512:
URL: https://github.com/apache/apisix-dashboard/issues/1512
## Background and purpose
To allow users to configure plugin templates in advance and bind the corresponding plugin templates when creating routes to achieve the fast configuration of routing plugin.
## Design options
### Front-end
- Plugin template configuration portal:
Add the Plugin Template Config button to the top of the route list, and enter the Plugin Template list page after clicking the button.
- New plugin template configuration list page
The list page is consistent with the style of other list pages and contains CRUD.
- Add a new plugin template configuration step page
After clicking Create or Edit in the plugin template configuration List page, you will enter the plugin template configuration Steps page.
The steps page is divided into two pages:
- Basic configuration information (e.g., desc) and plugin template configuration, which interacts with the Plugin Marketplace page.
- Preview page
- Update the Create Route configuration route page to include the plugin template selector, and render the corresponding plugin information after selecting the corresponding plugin template.
Policy is consistent with apisix:
- If the route is already configured with `plugins`, then the plugin configuration inside the Plugin config will be merged in.
- The same plugins will overwrite the original `plugins` plugins
#### Backend
Required interfaces:
- Plugin configuration list
- Plugin list search
- Create plugin configuration
- Update Plugin Configuration
- Delete plugin configuration
- May need to update Create and update routing interface, need @nic-chen to confirm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1512: Plugin template configuration
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1512:
URL: https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-798928006
@litesun can we close this issue now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1512: Plugin template configuration
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1512:
URL: https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-798932003
@LiteSun Do remember to use `close/resolve/fix #xxx` to link issue in PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #1512: Plugin template configuration
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #1512:
URL: https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-788404688
I am a little confused about how to use the plugin template. Do we need to bind the template to the target route manually? @LiteSun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on issue #1512: Plugin template configuration
Posted by GitBox <gi...@apache.org>.
LiteSun commented on issue #1512:
URL: https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-799045795
> @LiteSun can we close this issue now?
Sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on issue #1512: Plugin template configuration
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #1512:
URL: https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-785662803
will pugin support `tag`?
In this way, the management and grouping of plug-ins can be completed, which is more flexible
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on issue #1512: Plugin template configuration
Posted by GitBox <gi...@apache.org>.
LiteSun commented on issue #1512:
URL: https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-788493242
> I am a little confused about how to use the plugin template. Do we need to bind the template to the target route manually? @LiteSun
Yes, just like binding upstream in a route.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #1512: Plugin template configuration
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #1512:
URL: https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-788514923
> > I am a little confused about how to use the plugin template. Do we need to bind the template to the target route manually? @LiteSun
>
> Yes, just like binding upstream in a route.
Got it, and does the plugin template can also be bind to service?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on issue #1512: Plugin template configuration
Posted by GitBox <gi...@apache.org>.
LiteSun commented on issue #1512:
URL: https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-787597383
Apisix has submitted pr to complete this requirement: https://github.com/apache/apisix/pull/3703
The front-end page was changed as follows to complete the requirement.
1. new label search on the plugin template list page, similar to the route list label search.
2. add label field in the basic information configuration. similar to the creation of the route when the configuration label.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1512: Plugin template configuration
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1512:
URL: https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-785693420
> May need to update Create and update routing interface, need @nic-chen to confirm
need to update entity and schema for route.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun removed a comment on issue #1512: Plugin template configuration
Posted by GitBox <gi...@apache.org>.
LiteSun removed a comment on issue #1512:
URL: https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-785719936
Let me do more research on how to prevent the page from crashing if a field is missing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] spacewander edited a comment on issue #1512: Plugin template configuration
Posted by GitBox <gi...@apache.org>.
spacewander edited a comment on issue #1512:
URL: https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-787599224
>
>
> > > will pugin support `tag`?
> >
> >
> > > In this way, the management and grouping of plug-ins can be completed, which is more flexible
> >
> >
> > Good catch!
> > Does apisix plugin config support tag? Need @spacewander to confirm, if apisix supports it, I will update the tag to the solution.
>
> Ping @spacewander
Added in https://github.com/apache/apisix/pull/3703. Please have a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on issue #1512: Plugin template configuration
Posted by GitBox <gi...@apache.org>.
LiteSun commented on issue #1512:
URL: https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-799045638
closed by #1540
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on issue #1512: Plugin template configuration
Posted by GitBox <gi...@apache.org>.
LiteSun commented on issue #1512:
URL: https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-787567786
> > will pugin support `tag`?
>
> > In this way, the management and grouping of plug-ins can be completed, which is more flexible
>
>
>
> Good catch!
>
> Does apisix plugin config support tag? Need @spacewander to confirm, if apisix supports it, I will update the tag to the solution.
Ping @spacewander
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] spacewander commented on issue #1512: Plugin template configuration
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #1512:
URL: https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-787599224
>
>
> > > will pugin support `tag`?
> >
> >
> > > In this way, the management and grouping of plug-ins can be completed, which is more flexible
> >
> >
> > Good catch!
> > Does apisix plugin config support tag? Need @spacewander to confirm, if apisix supports it, I will update the tag to the solution.
>
> Ping @spacewander
Added in https://github.com/apache/apisix/pull/3703
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on issue #1512: Plugin template configuration
Posted by GitBox <gi...@apache.org>.
LiteSun commented on issue #1512:
URL: https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-788522822
> > > I am a little confused about how to use the plugin template. Do we need to bind the template to the target route manually? @LiteSun
> >
> >
> > Yes, just like binding upstream in a route.
>
> Got it, and does the plugin template can also be bind to service?
Binding service depends on apisix, which does not currently support this feature
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1512: Plugin template configuration
Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #1512:
URL: https://github.com/apache/apisix-dashboard/issues/1512
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on issue #1512: Plugin template configuration
Posted by GitBox <gi...@apache.org>.
LiteSun commented on issue #1512:
URL: https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-785677739
> will pugin support `tag`?
> In this way, the management and grouping of plug-ins can be completed, which is more flexible
Good catch!
Does apisix plugin config support tag? Need @spacewander to confirm, if apisix supports it, I will update the tag to the solution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on issue #1512: Plugin template configuration
Posted by GitBox <gi...@apache.org>.
LiteSun commented on issue #1512:
URL: https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-785719936
Let me do more research on how to prevent the page from crashing if a field is missing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org