You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2020/08/25 01:42:12 UTC
[native-toolchain-CR] IMPALA-10088 Fix DeadLock while run unifiedbetests on aarch64 platform
zhaorenhai@hotmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16357
Change subject: IMPALA-10088 Fix DeadLock while run unifiedbetests on aarch64 platform
......................................................................
IMPALA-10088 Fix DeadLock while run unifiedbetests on aarch64 platform
Add getting stacktrace implementation on aarch64 without using libunwind and gcc,
to solve this issue: https://github.com/gperftools/gperftools/issues/1184 .
This is a reference implementation of :
https://github.com/abseil/abseil-cpp/blob/master/absl/debugging/internal/stacktrace_aarch64-inl.inc
Change-Id: I8d7fffde111d0a57826291cec90df76194d58530
---
M buildall.sh
A source/gperftools/gperftools-2.5-patches/0002-Port-gperftools-to-adapt-aarch64.patch
2 files changed, 240 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/57/16357/1
--
To view, visit http://gerrit.cloudera.org:8080/16357
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d7fffde111d0a57826291cec90df76194d58530
Gerrit-Change-Number: 16357
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
[native-toolchain-CR] IMPALA-10088 Fix DeadLock while run unifiedbetests on aarch64 platform
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/16357 )
Change subject: IMPALA-10088 Fix DeadLock while run unifiedbetests on aarch64 platform
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16357/1/source/gperftools/gperftools-2.5-patches/0002-Port-gperftools-to-adapt-aarch64.patch
File source/gperftools/gperftools-2.5-patches/0002-Port-gperftools-to-adapt-aarch64.patch:
http://gerrit.cloudera.org:8080/#/c/16357/1/source/gperftools/gperftools-2.5-patches/0002-Port-gperftools-to-adapt-aarch64.patch@55
PS1, Line 55: stacktrace_arm64
> looks like a typo - stacktrace
Done
--
To view, visit http://gerrit.cloudera.org:8080/16357
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d7fffde111d0a57826291cec90df76194d58530
Gerrit-Change-Number: 16357
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Aug 2020 03:15:52 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-10088 Fix DeadLock while run unifiedbetests on aarch64 platform
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16357 )
Change subject: IMPALA-10088 Fix DeadLock while run unifiedbetests on aarch64 platform
......................................................................
Patch Set 2: Verified+1
TOOLCHAIN_BUILD_ID=55-dcf54c8601
--
To view, visit http://gerrit.cloudera.org:8080/16357
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d7fffde111d0a57826291cec90df76194d58530
Gerrit-Change-Number: 16357
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Aug 2020 21:26:18 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10088 Fix DeadLock while run unifiedbetests on aarch64 platform
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16357 )
Change subject: IMPALA-10088 Fix DeadLock while run unifiedbetests on aarch64 platform
......................................................................
IMPALA-10088 Fix DeadLock while run unifiedbetests on aarch64 platform
Add getting stacktrace implementation on aarch64 without using libunwind and gcc,
to solve this issue: https://github.com/gperftools/gperftools/issues/1184 .
This is a reference implementation of :
https://github.com/abseil/abseil-cpp/blob/master/absl/debugging/internal/stacktrace_aarch64-inl.inc
Change-Id: I8d7fffde111d0a57826291cec90df76194d58530
Reviewed-on: http://gerrit.cloudera.org:8080/16357
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>
---
M buildall.sh
A source/gperftools/gperftools-2.5-patches/0002-Port-gperftools-to-adapt-aarch64.patch
2 files changed, 240 insertions(+), 1 deletion(-)
Approvals:
Tim Armstrong: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16357
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d7fffde111d0a57826291cec90df76194d58530
Gerrit-Change-Number: 16357
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] IMPALA-10088 Fix DeadLock while run unifiedbetests on aarch64 platform
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16357 )
Change subject: IMPALA-10088 Fix DeadLock while run unifiedbetests on aarch64 platform
......................................................................
Patch Set 2: Code-Review+2
Will build the latest patch to verify then I can merge. Thank you!
--
To view, visit http://gerrit.cloudera.org:8080/16357
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d7fffde111d0a57826291cec90df76194d58530
Gerrit-Change-Number: 16357
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Aug 2020 18:05:56 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10088 Fix DeadLock while run unifiedbetests on aarch64 platform
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16357 )
Change subject: IMPALA-10088 Fix DeadLock while run unifiedbetests on aarch64 platform
......................................................................
Patch Set 1:
(2 comments)
Thanks for the contribution! I just saw one minor bug.
http://gerrit.cloudera.org:8080/#/c/16357/1/source/gperftools/gperftools-2.5-patches/0002-Port-gperftools-to-adapt-aarch64.patch
File source/gperftools/gperftools-2.5-patches/0002-Port-gperftools-to-adapt-aarch64.patch:
PS1:
I compared to https://github.com/abseil/abseil-cpp/blob/master/absl/debugging/internal/stacktrace_aarch64-inl.inc and it makes sense
http://gerrit.cloudera.org:8080/#/c/16357/1/source/gperftools/gperftools-2.5-patches/0002-Port-gperftools-to-adapt-aarch64.patch@55
PS1, Line 55: straktrace_arm64
looks like a typo - stacktrace
--
To view, visit http://gerrit.cloudera.org:8080/16357
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d7fffde111d0a57826291cec90df76194d58530
Gerrit-Change-Number: 16357
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Aug 2020 16:05:13 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-10088 Fix DeadLock while run unifiedbetests on aarch64 platform
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/16357 )
Change subject: IMPALA-10088 Fix DeadLock while run unifiedbetests on aarch64 platform
......................................................................
IMPALA-10088 Fix DeadLock while run unifiedbetests on aarch64 platform
Add getting stacktrace implementation on aarch64 without using libunwind and gcc,
to solve this issue: https://github.com/gperftools/gperftools/issues/1184 .
This is a reference implementation of :
https://github.com/abseil/abseil-cpp/blob/master/absl/debugging/internal/stacktrace_aarch64-inl.inc
Change-Id: I8d7fffde111d0a57826291cec90df76194d58530
---
M buildall.sh
A source/gperftools/gperftools-2.5-patches/0002-Port-gperftools-to-adapt-aarch64.patch
2 files changed, 240 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/57/16357/2
--
To view, visit http://gerrit.cloudera.org:8080/16357
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8d7fffde111d0a57826291cec90df76194d58530
Gerrit-Change-Number: 16357
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>