You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@serf.apache.org by Denis Kovalchuk <de...@visualsvn.com.INVALID> on 2022/10/08 16:57:32 UTC

[PATCH] Fix ssl test failures due to expired certificates (1.3.x branch)

Hello!

The 1.3.x branch has test failures due to expired test certificates:

[[
There were 14 failures:
1) test_ssl_trust_rootca: test\test_util.c:456:
expected <0> but was <120199>
2) test_ssl_certificate_chain_with_anchor: test\test_util.c:456: expected <0>
but was <120199>
3) test_ssl_certificate_chain_all_from_server: test\test_util.c:456: expected
<0> but was <120199>
4) test_ssl_no_servercert_callback_allok: test\test_util.c:456: expected <0>
but was <120170>
5) test_ssl_large_response: test\test_util.c:456: expected <0> but was <120170>
6) test_ssl_large_request: test\test_util.c:456: expected <0> but was <120170>
7) test_ssl_client_certificate: test\test_util.c:456: expected <0> but was
<120170>
8) test_ssl_future_server_cert: test\test_util.c:456: expected <0> but was
<120199>
9) test_setup_ssltunnel: test\test_util.c:456: expected <0> but was <120170>
10) test_ssltunnel_basic_auth: test\test_context.c:2133: expected <0> but was
<120170>
11) test_ssltunnel_basic_auth_server_has_keepalive_off:
test\test_context.c:2133: expected <0> but was <120170>
12) test_ssltunnel_basic_auth_proxy_has_keepalive_off:
test\test_context.c:2133: expected <0> but was <120170>
13) test_ssltunnel_basic_auth_proxy_close_conn_on_200resp:
test\test_context.c:2133: expected <0> but was <120170>
14) test_ssltunnel_digest_auth: test\test_util.c:456: expected <0> but was
<120170>
]]

I would like to propose updating the certificates by copying them from the
trunk. A similar fix was already made in r1792234 [1], but now certificates are
generated with a validity of 100 years [2].

[1] https://svn.apache.org/r1792234
[2] https://svn.apache.org/r1900591

Kind Regards,
Denis Kovalchuk

Re: [PATCH] Fix ssl test failures due to expired certificates (1.3.x branch)

Posted by Ivan Zhakov <ch...@gmail.com>.
On Sat, 8 Oct 2022 at 19:57, Denis Kovalchuk
<de...@visualsvn.com.invalid> wrote:

> Hello!
>
> The 1.3.x branch has test failures due to expired test certificates:
>
> [[
> There were 14 failures:
> 1) test_ssl_trust_rootca: test\test_util.c:456:
> expected <0> but was <120199>
> 2) test_ssl_certificate_chain_with_anchor: test\test_util.c:456: expected
> <0>
> but was <120199>
> 3) test_ssl_certificate_chain_all_from_server: test\test_util.c:456:
> expected
> <0> but was <120199>
> 4) test_ssl_no_servercert_callback_allok: test\test_util.c:456: expected
> <0>
> but was <120170>
> 5) test_ssl_large_response: test\test_util.c:456: expected <0> but was
> <120170>
> 6) test_ssl_large_request: test\test_util.c:456: expected <0> but was
> <120170>
> 7) test_ssl_client_certificate: test\test_util.c:456: expected <0> but was
> <120170>
> 8) test_ssl_future_server_cert: test\test_util.c:456: expected <0> but was
> <120199>
> 9) test_setup_ssltunnel: test\test_util.c:456: expected <0> but was
> <120170>
> 10) test_ssltunnel_basic_auth: test\test_context.c:2133: expected <0> but
> was
> <120170>
> 11) test_ssltunnel_basic_auth_server_has_keepalive_off:
> test\test_context.c:2133: expected <0> but was <120170>
> 12) test_ssltunnel_basic_auth_proxy_has_keepalive_off:
> test\test_context.c:2133: expected <0> but was <120170>
> 13) test_ssltunnel_basic_auth_proxy_close_conn_on_200resp:
> test\test_context.c:2133: expected <0> but was <120170>
> 14) test_ssltunnel_digest_auth: test\test_util.c:456: expected <0> but was
> <120170>
> ]]
>
> I would like to propose updating the certificates by copying them from the
> trunk. A similar fix was already made in r1792234 [1], but now
> certificates are
> generated with a validity of 100 years [2].
>
> Committed in r1909154. Thanks!

-- 
Ivan Zhakov