You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shindig.apache.org by hs...@apache.org on 2012/07/17 00:57:41 UTC
svn commit: r1362303 -
/shindig/trunk/features/src/main/javascript/features/dynamic-height.height/dynamic-height-height.js
Author: hsaputra
Date: Mon Jul 16 22:57:40 2012
New Revision: 1362303
URL: http://svn.apache.org/viewvc?rev=1362303&view=rev
Log:
Update comment in the dynamic height source to reflect the underlying algorithm used.
Modified:
shindig/trunk/features/src/main/javascript/features/dynamic-height.height/dynamic-height-height.js
Modified: shindig/trunk/features/src/main/javascript/features/dynamic-height.height/dynamic-height-height.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/dynamic-height.height/dynamic-height-height.js?rev=1362303&r1=1362302&r2=1362303&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/dynamic-height.height/dynamic-height-height.js (original)
+++ shindig/trunk/features/src/main/javascript/features/dynamic-height.height/dynamic-height-height.js Mon Jul 16 22:57:40 2012
@@ -30,24 +30,11 @@
gadgets.window = gadgets.window || {};
(function() {
-
- /**
- * Adjusts the gadget height
- * @param {number=} opt_height An optional preferred height in pixels. If not
- * specified, will attempt to fit the gadget to its content.
- * @member gadgets.window
- */
-
/**
* Calculate inner content height is hard and different between
- * browsers rendering in Strict vs. Quirks mode. We use a combination of
- * three properties within document.body and document.documentElement:
- * - scrollHeight
- * - offsetHeight
- * - clientHeight
- * These values differ significantly between browsers and rendering modes.
- * But there are patterns. It just takes a lot of time and persistence
- * to figure out.
+ * browsers rendering in Strict vs. Quirks mode.
+ * Currently, Shindig is using algorithm to iterate to all elements in the
+ * body to extract the height property and CSS if available.
*/
gadgets.window.getHeight = function() {
return gadgets.window.getDimen(1);