You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/29 22:24:26 UTC
[GitHub] [airflow] madison-ookla opened a new pull request #13373: Fix Jinja undefined upgrade check for non-templated objects
madison-ookla opened a new pull request #13373:
URL: https://github.com/apache/airflow/pull/13373
Resolves #13350
This PR fixes an issue with the `UndefinedJinjaVariablesRule` upgrade check wherein non-templated objects passed into tasks under fields that would be templated would break the upgrade check. The altered logic now correctly handles cases where regular objects are passed in directly without affecting the current tested behavior.
Also, the `test_invalid_check` test was quarantined in #12657 - I've removed the quarantine here in hopes that it might be less flaky.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13373: Fix Jinja undefined upgrade check for non-templated objects
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13373:
URL: https://github.com/apache/airflow/pull/13373#issuecomment-752278925
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #13373: Fix Jinja undefined upgrade check for non-templated objects
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #13373:
URL: https://github.com/apache/airflow/pull/13373
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] removed a comment on pull request #13373: Fix Jinja undefined upgrade check for non-templated objects
Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #13373:
URL: https://github.com/apache/airflow/pull/13373#issuecomment-752278925
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org