[GitHub] [spark] amuraru commented on issue #24502: [SPARK-27610][YARN] Shade netty native libraries

[GitBox <gi...@apache.org>]

amuraru commented on issue #24502: [SPARK-27610][YARN] Shade netty native libraries
URL: https://github.com/apache/spark/pull/24502#issuecomment-488590429
 
 
   > No. Bugs explain problems. PRs explain fixes. If you want to know more about the problem, look at the bug.
   
   I see your point and the note in the Contributing Guide:
   ```The PR title should be of the form [SPARK-xxxx][COMPONENT] Title, where SPARK-xxxx is the relevant JIRA number, COMPONENT is one of the PR categories shown at spark-prs.appspot.com and Title may be the JIRA’s title or a more specific title describing the PR itself.```
   
   I personally find it more consistent and easier to search (from a user perspective) the git history when the commit title describes the problem and not necessarily the fix, which can be described in the commit body.
   Anyway, updated the commit and PR title per your suggestion.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org