You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/03/17 09:08:30 UTC

[GitHub] [iotdb] bigreybear opened a new pull request #5271: [To rel/0.13][IOTDB-2759]Complete result of show template using or set on template

bigreybear opened a new pull request #5271:
URL: https://github.com/apache/iotdb/pull/5271


   This issue is fixed on 0.13 by a extra check on the related storage group of the target template.
   
   On 0.14 or further version, this issue will be avoided by a refactored Traverser.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls commented on pull request #5271: [To rel/0.13][IOTDB-2759]Complete result of show template using or set on template

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5271:
URL: https://github.com/apache/iotdb/pull/5271#issuecomment-1072047460


   
   [![Coverage Status](https://coveralls.io/builds/47481330/badge)](https://coveralls.io/builds/47481330)
   
   Coverage decreased (-0.05%) to 67.883% when pulling **a60130f6124cbea639f8ebed9860612ea95b7901 on bigreybear:i2759** into **d29ce0ab6945866e1849f5f20ee9f93f8e128200 on apache:rel/0.13**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #5271: [To rel/0.13][IOTDB-2759]Complete result of show template using or set on template

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5271:
URL: https://github.com/apache/iotdb/pull/5271#issuecomment-1072047460


   
   [![Coverage Status](https://coveralls.io/builds/47535338/badge)](https://coveralls.io/builds/47535338)
   
   Coverage decreased (-0.05%) to 67.878% when pulling **964871cbe2d809c3e03629855ab130919b5d742f on bigreybear:i2759** into **d29ce0ab6945866e1849f5f20ee9f93f8e128200 on apache:rel/0.13**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] bigreybear commented on a change in pull request #5271: [To rel/0.13][IOTDB-2759]Complete result of show template using or set on template

Posted by GitBox <gi...@apache.org>.
bigreybear commented on a change in pull request #5271:
URL: https://github.com/apache/iotdb/pull/5271#discussion_r830991044



##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/mtree/MTree.java
##########
@@ -1767,6 +1767,13 @@ public int getMountedNodeIndexOnMeasurementPath(PartialPath measurementPath)
             : template.getRelatedStorageGroup();
     List<String> resSet = new ArrayList<>();
     for (PartialPath sgPath : initPath) {
+      // before Traverser refactored as 0.14, need check storage group alone
+      if (getNodeByPath(sgPath).getSchemaTemplate() != null) {
+        if (templateName.equals(ONE_LEVEL_PATH_WILDCARD)
+            || templateName.equals(getNodeByPath(sgPath).getSchemaTemplate().getName())) {
+          resSet.add(sgPath.getFullPath());
+        }
+      }

Review comment:
       Thanks a lot ! And I have fixed as you suggested




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] MarcosZyk commented on a change in pull request #5271: [To rel/0.13][IOTDB-2759]Complete result of show template using or set on template

Posted by GitBox <gi...@apache.org>.
MarcosZyk commented on a change in pull request #5271:
URL: https://github.com/apache/iotdb/pull/5271#discussion_r830898715



##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/mtree/MTree.java
##########
@@ -1767,6 +1767,13 @@ public int getMountedNodeIndexOnMeasurementPath(PartialPath measurementPath)
             : template.getRelatedStorageGroup();
     List<String> resSet = new ArrayList<>();
     for (PartialPath sgPath : initPath) {
+      // before Traverser refactored as 0.14, need check storage group alone
+      if (getNodeByPath(sgPath).getSchemaTemplate() != null) {
+        if (templateName.equals(ONE_LEVEL_PATH_WILDCARD)
+            || templateName.equals(getNodeByPath(sgPath).getSchemaTemplate().getName())) {
+          resSet.add(sgPath.getFullPath());
+        }
+      }

Review comment:
       According to this scenario, if you want to include the sg node, it is better to use ```traverser.setPrefixMatch(true)``` .




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls commented on pull request #5271: [To rel/0.13][IOTDB-2759]Complete result of show template using or set on template

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5271:
URL: https://github.com/apache/iotdb/pull/5271#issuecomment-1072047460


   
   [![Coverage Status](https://coveralls.io/builds/47481330/badge)](https://coveralls.io/builds/47481330)
   
   Coverage decreased (-0.05%) to 67.883% when pulling **a60130f6124cbea639f8ebed9860612ea95b7901 on bigreybear:i2759** into **d29ce0ab6945866e1849f5f20ee9f93f8e128200 on apache:rel/0.13**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou merged pull request #5271: [To rel/0.13][IOTDB-2759]Complete result of show template using or set on template

Posted by GitBox <gi...@apache.org>.
HTHou merged pull request #5271:
URL: https://github.com/apache/iotdb/pull/5271


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org