[GitHub] [iceberg] izchen commented on issue #2838: Bucket partition transformation from timestamp throws error

[GitBox <gi...@apache.org>]

izchen commented on issue #2838:
URL: https://github.com/apache/iceberg/issues/2838#issuecomment-950351465


   I think this error will be thrown when we use timestamp, date, and binary types.
   
   https://github.com/apache/iceberg/blob/24896d84c586c6339752a69773409219c0c0ac02/spark/v3.0/spark/src/main/java/org/apache/iceberg/spark/IcebergSpark.java#L33-L38
   
   Maybe we should modify `bucket::apply` to `value -> bucket.apply(SparkValueConvertet.convert(sourceIcebergType, value))`
   
   I will submit a PR to modify the code and add more ut to cover all the atomic types of Spark.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org