You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "vVv-AA (via GitHub)" <gi...@apache.org> on 2024/10/16 08:03:49 UTC

Re: [I] SqlSensor parameter fails to capture the replication lag [airflow]

vVv-AA commented on issue #37437:
URL: https://github.com/apache/airflow/issues/37437#issuecomment-2416028015

   Hi @potiuk The issue seems to be abandoned. Is it ok if I work on it?
   
   
   There are 2 ways we can do this change.
   `SqlSensor` already takes a success and failure callable to which the first cell is passed. 
   1. A backward incompatible change and pass the whole row into the checker function. It passed checker function can then do its thing on the whole row.
   2. Add a selector parameter `Callable[[Tuple[Any]], bool]` which would take the whole row, and its output will be passed to the checker functions. To keep backward compatibility selector  can be be itemgetter(0) by default
   
   Which one would you prefer?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org