You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@netbeans.apache.org by vieiro <gi...@git.apache.org> on 2017/10/03 08:14:59 UTC

[GitHub] incubator-netbeans pull request #43: [NETBEANS-54] Module Review editor.book...

GitHub user vieiro opened a pull request:

    https://github.com/apache/incubator-netbeans/pull/43

    [NETBEANS-54] Module Review editor.bookmarks

    - No external libraries.
    - Checked Rat report: added license headres to qa-functional projects.
    - Skimmed through the module, did not notice additional problems

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vieiro/incubator-netbeans netbeans-54-module-review-editor.bookmarks

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-netbeans/pull/43.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #43
    
----
commit ed32d9b9c2886bde81ed1dedec4ec8de8efa5877
Author: Antonio Vieiro <an...@vieiro.net>
Date:   2017-10-03T08:10:20Z

    [NETBEANS-54] Module Review editor.bookmarks
    
    - No external libraries.
    - Checked Rat report: added license headres to qa-functional projects.
    - Skimmed through the module, did not notice additional problems

----


---

[GitHub] incubator-netbeans pull request #43: [NETBEANS-54] Module Review editor.book...

Posted by vieiro <gi...@git.apache.org>.

Github user vieiro closed the pull request at:

    https://github.com/apache/incubator-netbeans/pull/43


---

[GitHub] incubator-netbeans issue #43: [NETBEANS-54] Module Review editor.bookmarks

Posted by junichi11 <gi...@git.apache.org>.

Github user junichi11 commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/43
  
    Merged in 9117c00eabdabc179ccb4055044fcbb2ab40039a.
    
    @vieiro Do you mind closing this PR?
    
    Thanks!


---

[GitHub] incubator-netbeans issue #43: [NETBEANS-54] Module Review editor.bookmarks

Posted by matthiasblaesing <gi...@git.apache.org>.

Github user matthiasblaesing commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/43
  
    Looks good.


---

[GitHub] incubator-netbeans issue #43: [NETBEANS-54] Module Review editor.bookmarks

Posted by vieiro <gi...@git.apache.org>.

Github user vieiro commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/43
  
    Closing PR as requested.


---