[GitHub] [geode] PurelyApplied opened pull request #2603: GEODE-5860: Do not compile jar in test code.

["PurelyApplied (GitHub)" <gi...@apache.org>]

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [x] Have you written or updated unit tests to verify your changes?

- [n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2603 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on issue #2603: GEODE-5860: Do not compile jar in test code.

["PurelyApplied (GitHub)" <gi...@apache.org>]

Some overlap with #2593 in gradle files, but either identical or easy to merge.

[ Full content available at: https://github.com/apache/geode/pull/2603 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied closed pull request #2603: GEODE-5860: Do not compile jar in test code.

["PurelyApplied (GitHub)" <gi...@apache.org>]

[ pull request closed by PurelyApplied ]

[ Full content available at: https://github.com/apache/geode/pull/2603 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal commented on issue #2603: GEODE-5860: Do not compile jar in test code.

["jdeppe-pivotal (GitHub)" <gi...@apache.org>]

-1

Please don't do this. This is explicitly tying the test artifact creation to the build process. Future devs will scratch their heads wondering where how this artifact is being created. The test should be as self-contained as possible.

[ Full content available at: https://github.com/apache/geode/pull/2603 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org