You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/12 09:20:01 UTC

[GitHub] [airflow] eladkal commented on a diff in pull request #28882: Don't get ES log template from airflow local settings unless necessary

eladkal commented on code in PR #28882:
URL: https://github.com/apache/airflow/pull/28882#discussion_r1067880196


##########
airflow/config_templates/airflow_local_settings.py:
##########
@@ -313,6 +313,9 @@
                 "offset_field": ELASTICSEARCH_OFFSET_FIELD,
             },
         }
+        if tuple(map(int, version.split(".")[:3])) < (2, 3, 4):
+            # todo: remove this when ES min airflow version >= 2.3.4
+            ELASTIC_REMOTE_HANDLERS["task"].update(log_id_template=ELASTICSEARCH_LOG_ID_TEMPLATE)

Review Comment:
   This file is not part of the provider deployment so this code change will only be deployed in 2.5.X
   I think we need to make the adjustments regarding Airflow version in ES provider code?
   Did I miss something?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org