You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/01/24 19:26:03 UTC

[GitHub] [mynewt-mcumgr] vrahane opened a new pull request #61: mynewt_smp_svr: Stack is 8 byte aligned, 564 -> 568

vrahane opened a new pull request #61: mynewt_smp_svr: Stack is 8 byte aligned, 564 -> 568
URL: https://github.com/apache/mynewt-mcumgr/pull/61
 
 
   - On the mynewt side, OS main stack size should be set to 568 since taskstat
     shows the 8 byte aligned value for the stack size

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-mcumgr] vrahane merged pull request #61: mynewt_smp_svr: Stack is 8 byte aligned, 564 -> 568

Posted by GitBox <gi...@apache.org>.
vrahane merged pull request #61: mynewt_smp_svr: Stack is 8 byte aligned, 564 -> 568
URL: https://github.com/apache/mynewt-mcumgr/pull/61
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-mcumgr] vrahane commented on issue #61: mynewt_smp_svr: Stack is 8 byte aligned, 564 -> 568

Posted by GitBox <gi...@apache.org>.
vrahane commented on issue #61: mynewt_smp_svr: Stack is 8 byte aligned, 564 -> 568
URL: https://github.com/apache/mynewt-mcumgr/pull/61#issuecomment-578324140
 
 
   @utzig the problem was that the stack size, even though it corrects it, it is still not what we have specified as a syscfg which causes bit of a confusion while looking at the taskstats. Hence, the change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-mcumgr] vrahane commented on issue #61: mynewt_smp_svr: Stack is 8 byte aligned, 564 -> 568

Posted by GitBox <gi...@apache.org>.
vrahane commented on issue #61: mynewt_smp_svr: Stack is 8 byte aligned, 564 -> 568
URL: https://github.com/apache/mynewt-mcumgr/pull/61#issuecomment-578273990
 
 
   @utzig Why do you say that ? 
   ```
   juul-vipulrahane-mbt15:myproj vipul.rahane$ newtmgr --connstring /dev/cu.usbmodem141411 --conntype ble --connstring "peer_name=smp_svr" taskstat
         task pri tid  runtime      csw    stksz   stkuse last_checkin next_checkin
       ble_ll   0   2        3     1487       90       64        0        0
         idle 255   0     2646     1931       64       26        0        0
         main 127   1       42      397      568      510        0        0
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-mcumgr] utzig commented on issue #61: mynewt_smp_svr: Stack is 8 byte aligned, 564 -> 568

Posted by GitBox <gi...@apache.org>.
utzig commented on issue #61: mynewt_smp_svr: Stack is 8 byte aligned, 564 -> 568
URL: https://github.com/apache/mynewt-mcumgr/pull/61#issuecomment-578272037
 
 
   @vrahane This is OK, but it does not change anything in the results, `OS_STACK_ALIGN` does add the 4 bytes because the value is not 8-byte aligned.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services