You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "mcmellawatt (GitHub)" <gi...@apache.org> on 2018/10/02 02:01:33 UTC
[GitHub] [geode-examples] mcmellawatt opened pull request #69:
GEODE-5806: Adding example for durable messaging in client subscriptions
[ Full content available at: https://github.com/apache/geode-examples/pull/69 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-examples] mcmellawatt commented on issue #69:
GEODE-5806: Adding example for durable messaging in client subscriptions
Posted by "mcmellawatt (GitHub)" <gi...@apache.org>.
Thanks for the feedback @davebarnes97!
> "Events for durable queries and subscriptions are saved in queue" -> "save in a queue"
This one is actually just right out of our manual so I think the same fix needs to go there.
https://geode.apache.org/docs/guide/16/developing/events/implementing_durable_client_server_messaging.html
> "A simple cache listener is used to print output to terminal create events are received" -> "output to the terminal as create events are received"
Do you think it isn't worth mentioning that a cache listener is used to print to terminal? I suppose they can see that in the code, but technically cache listeners are a different topic and I didn't want users to be lost if they didn't know about cache listeners.
> "Run the example to demonstrate continues queries" -> "to demonstrate durable messaging"
This one is just a copy paste typo. Good catch, thanks!
[ Full content available at: https://github.com/apache/geode-examples/pull/69 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-examples] mcmellawatt closed pull request #69:
GEODE-5806: Adding example for durable messaging in client subscriptions
Posted by "mcmellawatt (GitHub)" <gi...@apache.org>.
[ pull request closed by mcmellawatt ]
[ Full content available at: https://github.com/apache/geode-examples/pull/69 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-examples] mcmellawatt commented on issue #69:
GEODE-5806: Adding example for durable messaging in client subscriptions
Posted by "mcmellawatt (GitHub)" <gi...@apache.org>.
Thanks for clarifying @davebarnes97! Appreciate the feedback.
[ Full content available at: https://github.com/apache/geode-examples/pull/69 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-examples] mcmellawatt commented on pull request #69:
GEODE-5806: Adding example for durable messaging in client subscriptions
Posted by "mcmellawatt (GitHub)" <gi...@apache.org>.
This was actually causing the existing `putall` example to fail if you ran it as a standalone example. The `putall` example (and now the durableMessaging) example both use a single server named "server", so Rat needs to ignore any files generated for the "server" folder.
[ Full content available at: https://github.com/apache/geode-examples/pull/69 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-examples] davebarnes97 commented on issue #69:
GEODE-5806: Adding example for durable messaging in client subscriptions
Posted by "davebarnes97 (GitHub)" <gi...@apache.org>.
> > "saved in queue" -> "save in a queue"
> This one is actually just right out of our manual so I think the same fix needs to go there.
Yes, thanks for the pointer.
> > "A simple cache listener is used to print output to terminal create events are received" -> "output to the terminal as create events are received"
>
> Do you think it isn't worth mentioning that a cache listener is used to print to terminal? I suppose they can see that in the code, but technically cache listeners are a different topic and I didn't want users to be lost if they didn't know about cache listeners.
Not my intention - unclear comment on my part. I'm suggesting the following:
- Leave the 'cache listener' part in place
- Replace "output to terminal create events are received" with "output to *the* terminal *as* create events are received"
[ Full content available at: https://github.com/apache/geode-examples/pull/69 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org