You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org> on 2011/03/29 02:08:05 UTC
[jira] [Created] (TAP5-1486) When Tapestry adds CSS and JS files to
the page, it should ensure that CSS files are above any JavaScript files
When Tapestry adds CSS and JS files to the page, it should ensure that CSS files are above any JavaScript files
---------------------------------------------------------------------------------------------------------------
Key: TAP5-1486
URL: https://issues.apache.org/jira/browse/TAP5-1486
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.2.5, 5.3.0
Reporter: Howard M. Lewis Ship
Priority: Minor
>From the "Audit" tab of Chrome Developer Tools:
The following external CSS files were included after an external JavaScript file in the document head. To ensure CSS files are downloaded in parallel, always include external CSS before external JavaScript
I think the best order would be:
Add all CSS files first; add them *before* any <script> tag or, failing that, at the end of the <head>.
Add all JavaScript files second; add them *after* any <link> tag or, failing that, at the end of the <head>.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TAP5-1486) When Tapestry adds CSS and JS files
to the page, it should ensure that CSS files are above any JavaScript files
Posted by "François Facon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
François Facon resolved TAP5-1486.
----------------------------------
Resolution: Fixed
Fix Version/s: 5.3
> When Tapestry adds CSS and JS files to the page, it should ensure that CSS files are above any JavaScript files
> ---------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1486
> URL: https://issues.apache.org/jira/browse/TAP5-1486
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3, 5.2.5
> Reporter: Howard M. Lewis Ship
> Assignee: François Facon
> Priority: Minor
> Fix For: 5.3
>
> Attachments: patch Data for DocumentLinkerImplTest.txt, patch DocumentLinkerImpl.txt
>
>
> From the "Audit" tab of Chrome Developer Tools:
> The following external CSS files were included after an external JavaScript file in the document head. To ensure CSS files are downloaded in parallel, always include external CSS before external JavaScript
> I think the best order would be:
> Add all CSS files first; add them *before* any <script> tag or, failing that, at the end of the <head>.
> Add all JavaScript files second; add them *after* any <link> tag or, failing that, at the end of the <head>.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TAP5-1486) When Tapestry adds CSS and JS files to
the page, it should ensure that CSS files are above any JavaScript files
Posted by "François Facon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
François Facon closed TAP5-1486.
--------------------------------
> When Tapestry adds CSS and JS files to the page, it should ensure that CSS files are above any JavaScript files
> ---------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1486
> URL: https://issues.apache.org/jira/browse/TAP5-1486
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3, 5.2.5
> Reporter: Howard M. Lewis Ship
> Assignee: François Facon
> Priority: Minor
> Fix For: 5.3
>
> Attachments: patch Data for DocumentLinkerImplTest.txt, patch DocumentLinkerImpl.txt
>
>
> From the "Audit" tab of Chrome Developer Tools:
> The following external CSS files were included after an external JavaScript file in the document head. To ensure CSS files are downloaded in parallel, always include external CSS before external JavaScript
> I think the best order would be:
> Add all CSS files first; add them *before* any <script> tag or, failing that, at the end of the <head>.
> Add all JavaScript files second; add them *after* any <link> tag or, failing that, at the end of the <head>.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TAP5-1486) When Tapestry adds CSS and JS files
to the page, it should ensure that CSS files are above any JavaScript files
Posted by "François Facon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
François Facon reassigned TAP5-1486:
------------------------------------
Assignee: François Facon
> When Tapestry adds CSS and JS files to the page, it should ensure that CSS files are above any JavaScript files
> ---------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1486
> URL: https://issues.apache.org/jira/browse/TAP5-1486
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3, 5.2.5
> Reporter: Howard M. Lewis Ship
> Assignee: François Facon
> Priority: Minor
> Attachments: patch Data for DocumentLinkerImplTest.txt, patch DocumentLinkerImpl.txt
>
>
> From the "Audit" tab of Chrome Developer Tools:
> The following external CSS files were included after an external JavaScript file in the document head. To ensure CSS files are downloaded in parallel, always include external CSS before external JavaScript
> I think the best order would be:
> Add all CSS files first; add them *before* any <script> tag or, failing that, at the end of the <head>.
> Add all JavaScript files second; add them *after* any <link> tag or, failing that, at the end of the <head>.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1486) When Tapestry adds CSS and JS files
to the page, it should ensure that CSS files are above any JavaScript files
Posted by "hien tran (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198069#comment-13198069 ]
hien tran commented on TAP5-1486:
---------------------------------
JS files can still be added before css.
Please have a look at: http://tapestry.1045711.n5.nabble.com/scripts-in-head-affect-placement-of-imported-scripts-in-tapestry-5-3-td5446328.html
> When Tapestry adds CSS and JS files to the page, it should ensure that CSS files are above any JavaScript files
> ---------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1486
> URL: https://issues.apache.org/jira/browse/TAP5-1486
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3, 5.2.5
> Reporter: Howard M. Lewis Ship
> Assignee: François Facon
> Priority: Minor
> Fix For: 5.3
>
> Attachments: patch Data for DocumentLinkerImplTest.txt, patch DocumentLinkerImpl.txt
>
>
> From the "Audit" tab of Chrome Developer Tools:
> The following external CSS files were included after an external JavaScript file in the document head. To ensure CSS files are downloaded in parallel, always include external CSS before external JavaScript
> I think the best order would be:
> Add all CSS files first; add them *before* any <script> tag or, failing that, at the end of the <head>.
> Add all JavaScript files second; add them *after* any <link> tag or, failing that, at the end of the <head>.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1486) When Tapestry adds CSS and JS files
to the page, it should ensure that CSS files are above any JavaScript files
Posted by "hien tran (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198069#comment-13198069 ]
hien tran commented on TAP5-1486:
---------------------------------
JS files can still be added before css.
Please have a look at: http://tapestry.1045711.n5.nabble.com/scripts-in-head-affect-placement-of-imported-scripts-in-tapestry-5-3-td5446328.html
> When Tapestry adds CSS and JS files to the page, it should ensure that CSS files are above any JavaScript files
> ---------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1486
> URL: https://issues.apache.org/jira/browse/TAP5-1486
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3, 5.2.5
> Reporter: Howard M. Lewis Ship
> Assignee: François Facon
> Priority: Minor
> Fix For: 5.3
>
> Attachments: patch Data for DocumentLinkerImplTest.txt, patch DocumentLinkerImpl.txt
>
>
> From the "Audit" tab of Chrome Developer Tools:
> The following external CSS files were included after an external JavaScript file in the document head. To ensure CSS files are downloaded in parallel, always include external CSS before external JavaScript
> I think the best order would be:
> Add all CSS files first; add them *before* any <script> tag or, failing that, at the end of the <head>.
> Add all JavaScript files second; add them *after* any <link> tag or, failing that, at the end of the <head>.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TAP5-1486) When Tapestry adds CSS and JS files
to the page, it should ensure that CSS files are above any JavaScript files
Posted by "François Facon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
François Facon reassigned TAP5-1486:
------------------------------------
Assignee: François Facon
> When Tapestry adds CSS and JS files to the page, it should ensure that CSS files are above any JavaScript files
> ---------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1486
> URL: https://issues.apache.org/jira/browse/TAP5-1486
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3, 5.2.5
> Reporter: Howard M. Lewis Ship
> Assignee: François Facon
> Priority: Minor
> Attachments: patch Data for DocumentLinkerImplTest.txt, patch DocumentLinkerImpl.txt
>
>
> From the "Audit" tab of Chrome Developer Tools:
> The following external CSS files were included after an external JavaScript file in the document head. To ensure CSS files are downloaded in parallel, always include external CSS before external JavaScript
> I think the best order would be:
> Add all CSS files first; add them *before* any <script> tag or, failing that, at the end of the <head>.
> Add all JavaScript files second; add them *after* any <link> tag or, failing that, at the end of the <head>.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1486) When Tapestry adds CSS and JS files
to the page, it should ensure that CSS files are above any JavaScript files
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053481#comment-13053481 ]
Hudson commented on TAP5-1486:
------------------------------
Integrated in tapestry-trunk-freestyle #378 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/378/])
TAP5-1486 : Add all CSS files first
ffacon : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1138594
Files :
* /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/internal/services/empty_document_with_scripts_at_top.txt
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/DocumentLinkerImpl.java
> When Tapestry adds CSS and JS files to the page, it should ensure that CSS files are above any JavaScript files
> ---------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1486
> URL: https://issues.apache.org/jira/browse/TAP5-1486
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.0, 5.2.5
> Reporter: Howard M. Lewis Ship
> Priority: Minor
> Attachments: patch Data for DocumentLinkerImplTest.txt, patch DocumentLinkerImpl.txt
>
>
> From the "Audit" tab of Chrome Developer Tools:
> The following external CSS files were included after an external JavaScript file in the document head. To ensure CSS files are downloaded in parallel, always include external CSS before external JavaScript
> I think the best order would be:
> Add all CSS files first; add them *before* any <script> tag or, failing that, at the end of the <head>.
> Add all JavaScript files second; add them *after* any <link> tag or, failing that, at the end of the <head>.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1486) When Tapestry adds CSS and JS files to
the page, it should ensure that CSS files are above any JavaScript files
Posted by "François Facon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
François Facon updated TAP5-1486:
---------------------------------
Attachment: patch Data for DocumentLinkerImplTest.txt
patch DocumentLinkerImpl.txt
As CSS are first include at the top, with this tiny change we add js file just after CSS inclusion.
But perhaps you have in mind more code in order to provide reorder all the elements.
> When Tapestry adds CSS and JS files to the page, it should ensure that CSS files are above any JavaScript files
> ---------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1486
> URL: https://issues.apache.org/jira/browse/TAP5-1486
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.0, 5.2.5
> Reporter: Howard M. Lewis Ship
> Priority: Minor
> Attachments: patch Data for DocumentLinkerImplTest.txt, patch DocumentLinkerImpl.txt
>
>
> From the "Audit" tab of Chrome Developer Tools:
> The following external CSS files were included after an external JavaScript file in the document head. To ensure CSS files are downloaded in parallel, always include external CSS before external JavaScript
> I think the best order would be:
> Add all CSS files first; add them *before* any <script> tag or, failing that, at the end of the <head>.
> Add all JavaScript files second; add them *after* any <link> tag or, failing that, at the end of the <head>.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TAP5-1486) When Tapestry adds CSS and JS files to
the page, it should ensure that CSS files are above any JavaScript files
Posted by "François Facon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
François Facon closed TAP5-1486.
--------------------------------
> When Tapestry adds CSS and JS files to the page, it should ensure that CSS files are above any JavaScript files
> ---------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1486
> URL: https://issues.apache.org/jira/browse/TAP5-1486
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3, 5.2.5
> Reporter: Howard M. Lewis Ship
> Assignee: François Facon
> Priority: Minor
> Fix For: 5.3
>
> Attachments: patch Data for DocumentLinkerImplTest.txt, patch DocumentLinkerImpl.txt
>
>
> From the "Audit" tab of Chrome Developer Tools:
> The following external CSS files were included after an external JavaScript file in the document head. To ensure CSS files are downloaded in parallel, always include external CSS before external JavaScript
> I think the best order would be:
> Add all CSS files first; add them *before* any <script> tag or, failing that, at the end of the <head>.
> Add all JavaScript files second; add them *after* any <link> tag or, failing that, at the end of the <head>.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TAP5-1486) When Tapestry adds CSS and JS files
to the page, it should ensure that CSS files are above any JavaScript files
Posted by "François Facon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
François Facon resolved TAP5-1486.
----------------------------------
Resolution: Fixed
Fix Version/s: 5.3
> When Tapestry adds CSS and JS files to the page, it should ensure that CSS files are above any JavaScript files
> ---------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1486
> URL: https://issues.apache.org/jira/browse/TAP5-1486
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3, 5.2.5
> Reporter: Howard M. Lewis Ship
> Assignee: François Facon
> Priority: Minor
> Fix For: 5.3
>
> Attachments: patch Data for DocumentLinkerImplTest.txt, patch DocumentLinkerImpl.txt
>
>
> From the "Audit" tab of Chrome Developer Tools:
> The following external CSS files were included after an external JavaScript file in the document head. To ensure CSS files are downloaded in parallel, always include external CSS before external JavaScript
> I think the best order would be:
> Add all CSS files first; add them *before* any <script> tag or, failing that, at the end of the <head>.
> Add all JavaScript files second; add them *after* any <link> tag or, failing that, at the end of the <head>.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1486) When Tapestry adds CSS and JS files to
the page, it should ensure that CSS files are above any JavaScript files
Posted by "François Facon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
François Facon updated TAP5-1486:
---------------------------------
Attachment: patch Data for DocumentLinkerImplTest.txt
patch DocumentLinkerImpl.txt
As CSS are first include at the top, with this tiny change we add js file just after CSS inclusion.
But perhaps you have in mind more code in order to provide reorder all the elements.
> When Tapestry adds CSS and JS files to the page, it should ensure that CSS files are above any JavaScript files
> ---------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1486
> URL: https://issues.apache.org/jira/browse/TAP5-1486
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.0, 5.2.5
> Reporter: Howard M. Lewis Ship
> Priority: Minor
> Attachments: patch Data for DocumentLinkerImplTest.txt, patch DocumentLinkerImpl.txt
>
>
> From the "Audit" tab of Chrome Developer Tools:
> The following external CSS files were included after an external JavaScript file in the document head. To ensure CSS files are downloaded in parallel, always include external CSS before external JavaScript
> I think the best order would be:
> Add all CSS files first; add them *before* any <script> tag or, failing that, at the end of the <head>.
> Add all JavaScript files second; add them *after* any <link> tag or, failing that, at the end of the <head>.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1486) When Tapestry adds CSS and JS files
to the page, it should ensure that CSS files are above any JavaScript files
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053481#comment-13053481 ]
Hudson commented on TAP5-1486:
------------------------------
Integrated in tapestry-trunk-freestyle #378 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/378/])
TAP5-1486 : Add all CSS files first
ffacon : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1138594
Files :
* /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/internal/services/empty_document_with_scripts_at_top.txt
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/DocumentLinkerImpl.java
> When Tapestry adds CSS and JS files to the page, it should ensure that CSS files are above any JavaScript files
> ---------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1486
> URL: https://issues.apache.org/jira/browse/TAP5-1486
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.0, 5.2.5
> Reporter: Howard M. Lewis Ship
> Priority: Minor
> Attachments: patch Data for DocumentLinkerImplTest.txt, patch DocumentLinkerImpl.txt
>
>
> From the "Audit" tab of Chrome Developer Tools:
> The following external CSS files were included after an external JavaScript file in the document head. To ensure CSS files are downloaded in parallel, always include external CSS before external JavaScript
> I think the best order would be:
> Add all CSS files first; add them *before* any <script> tag or, failing that, at the end of the <head>.
> Add all JavaScript files second; add them *after* any <link> tag or, failing that, at the end of the <head>.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira