You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "pepness (via GitHub)" <gi...@apache.org> on 2024/02/05 20:06:47 UTC

[PR] Fix how to define fallback values for a jdk installation in some xml files [netbeans]

pepness opened a new pull request, #7031:
URL: https://github.com/apache/netbeans/pull/7031

   The file `tools.jar` is no more on JDK since version 9, a file that differentiate between a JDK or JRE install would be `java.base.jmod`.
   
   
   NetBeans Testing:
   - Verify successful execution of libraries and licenses Ant test
   - Verify successful execution of Verify Sigtests
   - Verify successful assignment of the fallback value with `<echo message=...`
   - Started NetBeans and ensure the log didn't have any ERROR or new WARNINGS


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Fix how to define fallback values for a jdk installation in some xml files [netbeans]

Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #7031:
URL: https://github.com/apache/netbeans/pull/7031#discussion_r1481954449


##########
java/java.freeform/src/org/netbeans/modules/java/freeform/jdkselection/jdk.xml:
##########
@@ -159,7 +159,10 @@
         <!-- Define fallback values of some things. -->
         <property name="java.home.parent" location="${java.home}/.."/>
         <condition property="nbjdk.home" value="${java.home.parent}">
-            <available file="${java.home.parent}/lib/tools.jar" type="file"/>
+            <available file="${java.home.parent}/jmods/java.base.jmod" type="file"/>

Review Comment:
   My though was this (this is the original line 162) in combination with the addtion lines 163-165 you added:
   
   ```suggestion
               <available file="${java.home.parent}/lib/tools.jar" type="file"/>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Fix how to define fallback values for a jdk installation in some xml files [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7031:
URL: https://github.com/apache/netbeans/pull/7031#issuecomment-1931305263

   freeform are ant projects, right? adding the ant label


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Fix how to define fallback values for a jdk installation in some xml files [netbeans]

Posted by "pepness (via GitHub)" <gi...@apache.org>.
pepness merged PR #7031:
URL: https://github.com/apache/netbeans/pull/7031


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Fix how to define fallback values for a jdk installation in some xml files [netbeans]

Posted by "pepness (via GitHub)" <gi...@apache.org>.
pepness commented on PR #7031:
URL: https://github.com/apache/netbeans/pull/7031#issuecomment-1931053575

   I added a condition to take into account JDK 8.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists