Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

[Stephan Erb <se...@apache.org>]

> On Feb. 15, 2017, 9:14 a.m., Aurora ReviewBot wrote:
> > Master (9ea8979) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> >                      
> >                      ==================== FAILURES ====================
> >                       test_simple_process_filesystem_isolator_launch_info 
> >                      
> >                      args = (), kw = {}
> >                      
> >                          @wraps(f)
> >                          def _inner(*args, **kw):
> >                              self._patch_dict()
> >                              try:
> >                      >           return f(*args, **kw)
> >                      
> >                      .pants.d/python-setup/chroots/22bbf744265cd5201eb0521a411354ed4e0941bf/.deps/mock-1.0.1-py2-none-any.whl/mock.py:1618: 
> >                      _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
> >                      src/test/python/apache/thermos/core/test_process.py:190: in test_simple_process_filesystem_isolator_launch_info
> >                          '"working_directory": "%s", "user": "None", "rootfs": "/some/path/taskfs"}\n' % (sandbox))
> >                      _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
> >                      
> >                      taskpath = <apache.thermos.common.path.TaskPath object at 0x7fe308111f50>
> >                      log_name = 'stdout'
> >                      expected_content = 'launch --unshare_namespace_mnt --launch_info={"command": {"shell": false, "arguments": ["/bin/bash", "-c", "echo hell..."value": "/bin/bash"}, "working_directory": "/tmp/tmpbSrh8y/sandbox", "user": "None", "rootfs": "/some/path/taskfs"}\n'
> >                      
> >                          def assert_log_content(taskpath, log_name, expected_content):
> >                            log = taskpath.with_filename(log_name).getpath('process_logdir')
> >                            assert os.path.exists(log)
> >                            with open(log, 'r') as fp:
> >                      >       assert fp.read() == expected_content
> >                      E       assert 'launch --uns.../bin/bash"}\n' == 'launch --unsh...th/taskfs"}\n'
> >                      E         - launch --unshare_namespace_mnt --working_directory=/tmp/tmpbSrh8y/sandbox --rootfs=/some/path/taskfs --user=None --command={"shell": false, "arguments": ["/bin/bash", "-c", "echo hello world"], "value": "/bin/bash"}
> >                      E         + launch --unshare_namespace_mnt --launch_info={"command": {"shell": false, "arguments": ["/bin/bash", "-c", "echo hello world"], "value": "/bin/bash"}, "working_directory": "/tmp/tmpbSrh8y/sandbox", "user": "None", "rootfs": "/some/path/taskfs"}
> >                      
> >                      src/test/python/apache/thermos/core/test_process.py:364: AssertionError
> >                       generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/aaf4d108c31293299a0839bdc404a91802f80937.xml 
> >                       1 failed, 780 passed, 6 skipped, 1 warnings in 380.32 seconds 
> >                      
> > FAILURE
> > 
> > 
> > 08:14:12 06:56   [complete]
> >                FAILURE
> > 
> > 
> > I will refresh this build result if you post a review containing "@ReviewBot retry"

this looks like a legit test failure.


- Stephan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55951/#review165662
-----------------------------------------------------------


On Feb. 15, 2017, 6:40 a.m., Santhosh Kumar Shanmugham wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55951/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2017, 6:40 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Karthik Anantha Padmanabhan.
> 
> 
> Bugs: AURORA-1882
>     https://issues.apache.org/jira/browse/AURORA-1882
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> MesosContainerizer has updated the command line parameters in 1.2.0 and
> consolidated the individual arguments into a single ContainerLaunchInfo
> proto buf message. Update ThermosExecutor to use the new `--launch_info`
> parameter to be compatible with MesosContainerizer also check the
> containerizer binary interface to determine to be backward-compatible.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/common/process_util.py 54e716b726fc02f3901f1b9143d3fa253511e29b 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py a3b5a22a805753d42e97f8f1e4e3dab7d3c9c507 
>   src/test/python/apache/thermos/core/test_process.py 520390217f691b9136cb4d36262be3d372a16509 
> 
> 
> Diff: https://reviews.apache.org/r/55951/diff/2/
> 
> 
> Testing
> -------
> 
> build-support/jenkins/build.sh
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>