[GitHub] [hive] belugabehr commented on pull request #1301: HIVE-23901: Overhead of Logger in ColumnStatsMerger damage the perfor…

[GitBox <gi...@apache.org>]

belugabehr commented on pull request #1301:
URL: https://github.com/apache/hive/pull/1301#issuecomment-662777247


   The current implementation is purposeful.  This is an abstract class.  The idea is that every subclass gets it's own logger.  With the implementation proposed in this PR, every subclass will have the same logger.  This makes logging very difficult to tease out.
   
   Can you please elaborate on the performance implications here?  If it's absolutely required, it is better that each subclass have their own Logger than to inherit a logger in this fashion.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org