[GitHub] [arrow] zeroshade commented on a diff in pull request #34748: GH-34724: [Go] Add Schema AddField

["zeroshade (via GitHub)" <gi...@apache.org>]

zeroshade commented on code in PR #34748:
URL: https://github.com/apache/arrow/pull/34748#discussion_r1152372019


##########
go/arrow/array/table.go:
##########
@@ -198,6 +198,26 @@ func NewTableFromRecords(schema *arrow.Schema, recs []arrow.Record) *simpleTable
 }
 
 func (tbl *simpleTable) Schema() *arrow.Schema      { return tbl.schema }
+
+func (tbl *simpleTable) AddColumn(i int, field arrow.Field, column arrow.Column) (*simpleTable, error) {

Review Comment:
   Would `InsertColumn` be a better name? You also need to add this to the `Table` interface.
   
   When you do, please add a documentation comment to clarify the semantics that this creates a new table that needs to be released instead of modifying the existing table.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org