You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "David Van Couvering (JIRA)" <de...@db.apache.org> on 2006/01/20 18:32:42 UTC
[jira] Created: (DERBY-843) Internationalize messages in
SectionManager to XaException in org.apache.derby.client.am
Internationalize messages in SectionManager to XaException in org.apache.derby.client.am
----------------------------------------------------------------------------------------
Key: DERBY-843
URL: http://issues.apache.org/jira/browse/DERBY-843
Project: Derby
Type: Sub-task
Reporter: David Van Couvering
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-843) Internationalize messages in
SectionManager to XaException in org.apache.derby.client.am
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-843?page=all ]
David Van Couvering updated DERBY-843:
--------------------------------------
Attachment: DERBY-843-2.diff
This patch went through a derbyall run and I updated all the output files. However I also had to modify Statement.java to get matching SQL States between network and embedded, so I am doing a new run of derbynetclientmats. Pending any comments on this patch and a clean run of derbynetclientmats I'll go ahead and commit
> Internationalize messages in SectionManager to XaException in org.apache.derby.client.am
> ----------------------------------------------------------------------------------------
>
> Key: DERBY-843
> URL: http://issues.apache.org/jira/browse/DERBY-843
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: David Van Couvering
> Attachments: DERBY-843-2.diff, DERBY-843.diff
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (DERBY-843) Internationalize messages in
SectionManager to XaException in org.apache.derby.client.am
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-843?page=all ]
David Van Couvering resolved DERBY-843:
---------------------------------------
Resolution: Fixed
Checked in revision 395484
> Internationalize messages in SectionManager to XaException in org.apache.derby.client.am
> ----------------------------------------------------------------------------------------
>
> Key: DERBY-843
> URL: http://issues.apache.org/jira/browse/DERBY-843
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: David Van Couvering
> Attachments: DERBY-843-2.diff, DERBY-843.diff
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-843) Internationalize messages in
SectionManager to XaException in org.apache.derby.client.am
Posted by "Knut Anders Hatlen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-843?page=comments#action_12375084 ]
Knut Anders Hatlen commented on DERBY-843:
------------------------------------------
Hi David,
I got a bit worried when you said "This patch went through a derbyall
run and I updated all the output files." Does this mean you ran
derbyall and just copied the out files from the failing tests?
I have read through your patch, and I have some questions:
The canons for lang/updatableResultSet.java have a lot of diffs like
this one:
Test updateBlob on a readonly resultset
Using column position as first parameter to updateBlob
- Got expected exception : JDBC 3 method called - not yet supported
Using column name as first parameter to updateBlob
- Got expected exception : JDBC 3 method called - not yet supported
Could you explain why we shouldn't expect the exception any more?
Haven't you only changed the message?
The same canons also have this diff, which I don't understand:
{7,null}
{8,8}
+ {82,82}
C51,C52
--- ---
In jdbc4/StatementTest.java you have made this change:
+ assertEquals("Unexpected SQL state for performing " +
+ "operations on a closed statement.",
+ SQLState.NO_CURRENT_CONNECTION,
+ sqle.getSQLState());
I think it was concluded in a recent thread that using constants from
SQLState.java should be avoided in the tests. Should we change this to
a hard-coded string?
> Internationalize messages in SectionManager to XaException in org.apache.derby.client.am
> ----------------------------------------------------------------------------------------
>
> Key: DERBY-843
> URL: http://issues.apache.org/jira/browse/DERBY-843
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: David Van Couvering
> Attachments: DERBY-843-2.diff, DERBY-843.diff
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-843) Internationalize messages in
SectionManager to XaException in org.apache.derby.client.am
Posted by "Mike Matrigali (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-843?page=all ]
Mike Matrigali updated DERBY-843:
---------------------------------
Component: Network Client
Description:
Environment:
> Internationalize messages in SectionManager to XaException in org.apache.derby.client.am
> ----------------------------------------------------------------------------------------
>
> Key: DERBY-843
> URL: http://issues.apache.org/jira/browse/DERBY-843
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (DERBY-843) Internationalize messages in
SectionManager to XaException in org.apache.derby.client.am
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-843?page=all ]
David Van Couvering reassigned DERBY-843:
-----------------------------------------
Assign To: David Van Couvering
> Internationalize messages in SectionManager to XaException in org.apache.derby.client.am
> ----------------------------------------------------------------------------------------
>
> Key: DERBY-843
> URL: http://issues.apache.org/jira/browse/DERBY-843
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: David Van Couvering
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-843) Internationalize messages in
SectionManager to XaException in org.apache.derby.client.am
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-843?page=comments#action_12402446 ]
David Van Couvering commented on DERBY-843:
-------------------------------------------
Yes, the client and engine should match. I'm not able to catch all of these. It would be great if you could log a separate bug on this. Alternately, you can re-open this one.
Thanks,
David
> Internationalize messages in SectionManager to XaException in org.apache.derby.client.am
> ----------------------------------------------------------------------------------------
>
> Key: DERBY-843
> URL: http://issues.apache.org/jira/browse/DERBY-843
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: David Van Couvering
> Attachments: DERBY-843-2.diff, DERBY-843.diff
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-843) Internationalize messages in
SectionManager to XaException in org.apache.derby.client.am
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-843?page=comments#action_12375198 ]
David Van Couvering commented on DERBY-843:
-------------------------------------------
OK, it appears that in the patch I had applied the JDK 1.3 version of updatableResultSet.out to the jdk16 directory. My own run of derbynetclientmats uncovered this as a problem, and I've fixed it. This answers Knut's first questions. I have also modified StatementTest.java to use SQLStateConstants.CONNECTION_EXCEPTION_CONNECTION_DOES_NOT_EXIST rather than SQLState.NO_CURRENT_CONNECTION.
I'm dong a final test run and then I'll check in. I'll mark DERBY-1198 as fixed too when I do the checkin.
> Internationalize messages in SectionManager to XaException in org.apache.derby.client.am
> ----------------------------------------------------------------------------------------
>
> Key: DERBY-843
> URL: http://issues.apache.org/jira/browse/DERBY-843
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: David Van Couvering
> Attachments: DERBY-843-2.diff, DERBY-843.diff
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-843) Internationalize messages in
SectionManager to XaException in org.apache.derby.client.am
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-843?page=all ]
David Van Couvering updated DERBY-843:
--------------------------------------
Attachment: DERBY-843.diff
Attaching the patch for this item. This internationalizes SectionManager to XaException *and* cleans up some other hardcoded English messages that I detected in a rescan of the client.am package.
This patch is *not* intended for inclusion. I am looking for review comments while I run derbyall. The final patch I am sure will include changes to master files, but I thought in the meantime folks can look at the source changes I have made.
> Internationalize messages in SectionManager to XaException in org.apache.derby.client.am
> ----------------------------------------------------------------------------------------
>
> Key: DERBY-843
> URL: http://issues.apache.org/jira/browse/DERBY-843
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: David Van Couvering
> Attachments: DERBY-843.diff
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-843) Internationalize messages in
SectionManager to XaException in org.apache.derby.client.am
Posted by "Kathey Marsden (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-843?page=comments#action_12402427 ]
Kathey Marsden commented on DERBY-843:
--------------------------------------
In DERBY-1219, deepa pointed out that for the scenario where both connection and statement are closed and an operation is performed on a closed statement we have:
Embbedded: SQLSTATE: XJ012, Message: Statement Closed
Client before DERBY-843 fix: SQLSTATE = null, message = Statement closed
Client after DERBY-843 fix: SQLSTATE: 08003, Message: connection closed
Should the client have been changed to match embedded in this case?
> Internationalize messages in SectionManager to XaException in org.apache.derby.client.am
> ----------------------------------------------------------------------------------------
>
> Key: DERBY-843
> URL: http://issues.apache.org/jira/browse/DERBY-843
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: David Van Couvering
> Attachments: DERBY-843-2.diff, DERBY-843.diff
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-843) Internationalize messages in
SectionManager to XaException in org.apache.derby.client.am
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-843?page=comments#action_12363852 ]
David Van Couvering commented on DERBY-843:
-------------------------------------------
XN251 - XN300
> Internationalize messages in SectionManager to XaException in org.apache.derby.client.am
> ----------------------------------------------------------------------------------------
>
> Key: DERBY-843
> URL: http://issues.apache.org/jira/browse/DERBY-843
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (DERBY-843) Internationalize messages in
SectionManager to XaException in org.apache.derby.client.am
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-843?page=all ]
David Van Couvering closed DERBY-843:
-------------------------------------
> Internationalize messages in SectionManager to XaException in org.apache.derby.client.am
> ----------------------------------------------------------------------------------------
>
> Key: DERBY-843
> URL: http://issues.apache.org/jira/browse/DERBY-843
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: David Van Couvering
> Attachments: DERBY-843-2.diff, DERBY-843.diff
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-843) Internationalize messages in
SectionManager to XaException in org.apache.derby.client.am
Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-843?page=comments#action_12375164 ]
David Van Couvering commented on DERBY-843:
-------------------------------------------
Hi, Knut, thanks for looking at this.
I did copy the output files, but only after inspecting them. It appears your inspection uncovered some diffs I have missed, and I will look into this.
The use of SQLState was there before, but you are right, I should go ahead and fix this. I logged a bug for this a while back (DERBY-1198).
> Internationalize messages in SectionManager to XaException in org.apache.derby.client.am
> ----------------------------------------------------------------------------------------
>
> Key: DERBY-843
> URL: http://issues.apache.org/jira/browse/DERBY-843
> Project: Derby
> Type: Sub-task
> Components: Network Client
> Reporter: David Van Couvering
> Assignee: David Van Couvering
> Attachments: DERBY-843-2.diff, DERBY-843.diff
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira