You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/07/08 03:25:09 UTC

[GitHub] [servicecomb-service-center] humingcheng commented on a change in pull request #660: add more action for code quality (#657)

humingcheng commented on a change in pull request #660:
URL: https://github.com/apache/servicecomb-service-center/pull/660#discussion_r450838113



##########
File path: server/plugin/registry/metrics.go
##########
@@ -50,7 +51,7 @@ var (
 			Subsystem:  "db",
 			Name:       "backend_operation_durations_microseconds",
 			Help:       "Latency of backend operation",
-			Objectives: prometheus.DefObjectives,
+			Objectives: map[float64]float64{0.5: 0.05, 0.9: 0.01, 0.99: 0.001},

Review comment:
       没有理解为什么不可以用prometheus.DefObjectives？而且这个硬编码的map重复出现了很多次，建议提取出一个变量。




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org