[GitHub] [openwhisk] upgle commented on a diff in pull request #5280: Retry on any errors.

[GitBox <gi...@apache.org>]

upgle commented on code in PR #5280:
URL: https://github.com/apache/openwhisk/pull/5280#discussion_r918979979


##########
tests/src/test/scala/org/apache/openwhisk/common/RunCliCmdTests.scala:
##########
@@ -74,16 +74,16 @@ class RunCliCmdTests extends FlatSpec with RunCliCmd with BeforeAndAfterEach {
     cmdCount shouldBe 1
   }
 
-  it should "not retry commands if failure is not retriable" in {
-    Seq(MISUSE_EXIT, ERROR_EXIT, SUCCESS_EXIT).foreach { code =>
+  it should "retry commands if any failure is happen" in {
+    Seq(MISUSE_EXIT, ERROR_EXIT).foreach { code =>
       cmdCount = 0
 
       rr = Some(TestRunResult(code))
       noException shouldBe thrownBy {
         cli(Seq.empty, expectedExitCode = DONTCARE_EXIT, retriesOnNetworkError = 3)

Review Comment:
   It seems the `retriesOnNetworkError` variable name also needs to be updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org