You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by gu...@apache.org on 2014/07/30 00:25:20 UTC
svn commit: r1614504 - in /hive/trunk/ql/src:
java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/
test/results/clientpositive/ test/results/clientpositive/tez/
Author: gunther
Date: Tue Jul 29 22:25:20 2014
New Revision: 1614504
URL: http://svn.apache.org/r1614504
Log:
HIVE-7535: Make use of number of nulls column statistics in filter rule (Prasanth J via Gunther Hagleitner)
Modified:
hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
hive/trunk/ql/src/test/results/clientpositive/annotate_stats_filter.q.out
hive/trunk/ql/src/test/results/clientpositive/annotate_stats_join.q.out
hive/trunk/ql/src/test/results/clientpositive/metadataonly1.q.out
hive/trunk/ql/src/test/results/clientpositive/tez/metadataonly1.q.out
Modified: hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java?rev=1614504&r1=1614503&r2=1614504&view=diff
==============================================================================
--- hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java (original)
+++ hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java Tue Jul 29 22:25:20 2014
@@ -401,7 +401,6 @@ public class StatsRulesProcFactory {
long numRows = stats.getNumRows();
- // evaluate similar to "col = constant" expr
if (pred instanceof ExprNodeGenericFuncDesc) {
ExprNodeGenericFuncDesc genFunc = (ExprNodeGenericFuncDesc) pred;
@@ -413,9 +412,7 @@ public class StatsRulesProcFactory {
String tabAlias = colDesc.getTabAlias();
ColStatistics cs = stats.getColumnStatisticsForColumn(tabAlias, colName);
if (cs != null) {
- long dvs = cs.getCountDistint();
- numRows = dvs == 0 ? numRows / 2 : numRows / dvs;
- return numRows;
+ return cs.getNumNulls();
}
}
}
Modified: hive/trunk/ql/src/test/results/clientpositive/annotate_stats_filter.q.out
URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/test/results/clientpositive/annotate_stats_filter.q.out?rev=1614504&r1=1614503&r2=1614504&view=diff
==============================================================================
Files hive/trunk/ql/src/test/results/clientpositive/annotate_stats_filter.q.out (original) and hive/trunk/ql/src/test/results/clientpositive/annotate_stats_filter.q.out Tue Jul 29 22:25:20 2014 differ
Modified: hive/trunk/ql/src/test/results/clientpositive/annotate_stats_join.q.out
URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/test/results/clientpositive/annotate_stats_join.q.out?rev=1614504&r1=1614503&r2=1614504&view=diff
==============================================================================
Files hive/trunk/ql/src/test/results/clientpositive/annotate_stats_join.q.out (original) and hive/trunk/ql/src/test/results/clientpositive/annotate_stats_join.q.out Tue Jul 29 22:25:20 2014 differ
Modified: hive/trunk/ql/src/test/results/clientpositive/metadataonly1.q.out
URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/test/results/clientpositive/metadataonly1.q.out?rev=1614504&r1=1614503&r2=1614504&view=diff
==============================================================================
Files hive/trunk/ql/src/test/results/clientpositive/metadataonly1.q.out (original) and hive/trunk/ql/src/test/results/clientpositive/metadataonly1.q.out Tue Jul 29 22:25:20 2014 differ
Modified: hive/trunk/ql/src/test/results/clientpositive/tez/metadataonly1.q.out
URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/test/results/clientpositive/tez/metadataonly1.q.out?rev=1614504&r1=1614503&r2=1614504&view=diff
==============================================================================
Files hive/trunk/ql/src/test/results/clientpositive/tez/metadataonly1.q.out (original) and hive/trunk/ql/src/test/results/clientpositive/tez/metadataonly1.q.out Tue Jul 29 22:25:20 2014 differ