[GitHub] mrutkows commented on a change in pull request #3720: Update the document regarding Open JDK and Oracle JDK

[GitBox <gi...@apache.org>]

mrutkows commented on a change in pull request #3720: Update the document regarding Open JDK and Oracle JDK
URL: https://github.com/apache/incubator-openwhisk/pull/3720#discussion_r193089780
 
 

 ##########
 File path: tools/ubuntu-setup/java8.sh
 ##########
 @@ -19,10 +19,20 @@
 set -e
 set -x
 
-if [ "$(lsb_release -cs)" == "trusty" ]; then
+JAVA_SOURCE=${1:-"open"}
+
+if [ "$JAVA_SOURCE" != "oracle" ] ; then
+    if [ "$(lsb_release -cs)" == "trusty" ]; then
+        sudo apt-get install -y software-properties-common python-software-properties
+        sudo add-apt-repository ppa:jonathonf/openjdk -y
 
 Review comment:
   Not sure if this PPA build is "trusted"... https://askubuntu.com/questions/464755/how-to-install-openjdk-8-on-14-04-lts ... perhaps we should discuss this on mailing list?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services