You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by sureshanaparti <gi...@git.apache.org> on 2015/12/16 13:34:35 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-9182: Some running VMs turned ...
GitHub user sureshanaparti opened a pull request:
https://github.com/apache/cloudstack/pull/1252
CLOUDSTACK-9182: Some running VMs turned off on manual migration when auto migration failed while host preparing for maintenance.
CLOUDSTACK-9182: Some running VMs turned off on manual migration when auto migration failed while host preparing for maintenance.
Fix: Block VMOperations if Host in PrepareForMaintenance mode. VM operations (Stop, Reboot, Destroy, Migrate to host) are not allowed when Host in PrepareForMaintenance mode.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sureshanaparti/cloudstack CLOUDSTACK-9182
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1252.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1252
----
commit 98186f9e6a3f659ac294a30b2243070961c167fe
Author: Suresh Kumar Anaparti <su...@citrix.com>
Date: 2015-12-16T12:31:30Z
CLOUDSTACK-9182: Some running VMs turned off on manual migration when auto migration failed while host preparing for maintenance.
Fix: Block VMOperations if Host in PrepareForMaintenance mode. VM operations (Stop, Reboot, Destroy, Migrate to host) are not allowed when Host in PrepareForMaintenance mode.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1252: CLOUDSTACK-9182: Some running VMs turned off ...
Posted by sureshanaparti <gi...@git.apache.org>.
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1252#discussion_r90602385
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -4468,6 +4472,16 @@ private boolean checkIfHostIsDedicated(HostVO host) {
}
}
+ private void checkIfHostOfVMIsInPrepareForMaintenanceState(Long hostId, Long vmId, String operation) {
--- End diff --
@alexandrelimassantana Added javadoc for the method "checkIfHostOfVMIsInPrepareForMaintenanceState"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1252: CLOUDSTACK-9182: Some running VMs turned off on manu...
Posted by cloudmonger <gi...@git.apache.org>.
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/1252
### ACS CI BVT Run
**Sumarry:**
Build Number 397
Hypervisor xenserver
NetworkType Advanced
Passed=102
Failed=3
Skipped=7
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
* test_non_contigiousvlan.py
* test_extendPhysicalNetworkVlan Failed
* test_routers_network_ops.py
* test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 2 runs
* test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 2 runs
**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm
**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1252: CLOUDSTACK-9182: Some running VMs turned off on manu...
Posted by sureshanaparti <gi...@git.apache.org>.
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1252
@rhtyd Rebased against 4.9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9182: Some running VMs turned ...
Posted by bvbharatk <gi...@git.apache.org>.
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1252#issuecomment-222304350
### ACS CI BVT Run
**Sumarry:**
Build Number 72
Hypervisor xenserver
NetworkType Advanced
Passed=73
Failed=0
Skipped=3
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm
**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9182: Some running VMs turned ...
Posted by alexandrelimassantana <gi...@git.apache.org>.
Github user alexandrelimassantana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1252#discussion_r55169762
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -4468,6 +4472,16 @@ private boolean checkIfHostIsDedicated(HostVO host) {
}
}
+ private void checkIfHostOfVMIsInPrepareForMaintenanceState(Long hostId, Long vmId, String operation) {
--- End diff --
Hello @sureshanaparti
I think this method can use a Javadoc. Since it's supposed to check something and doesn't return nothing, it might make someone have to open the code to check what does it do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9182: Some running VMs turned ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1252#issuecomment-170357234
@rodrigo93 I agree but it seems that this behavioral change might be a compatibility problem to some. I would like this to be tweekable with a setting. People may rely on exception being thrown atm.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9182: Some running VMs turned ...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1252#issuecomment-216210063
@sureshanaparti please rebase against latest master, how do we test your change; additional tests would be great
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1252: CLOUDSTACK-9182: Some running VMs turned off on manu...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1252
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9182: Some running VMs turned ...
Posted by rodrigo93 <gi...@git.apache.org>.
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1252#issuecomment-170381257
@DaanHoogland I see... With that option in settings, things could be more manageable. That is a good suggestion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9182: Some running VMs turned ...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1252#issuecomment-216209760
@
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1252: CLOUDSTACK-9182: Some running VMs turned off on manu...
Posted by cloudmonger <gi...@git.apache.org>.
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/1252
### ACS CI BVT Run
**Sumarry:**
Build Number 327
Hypervisor xenserver
NetworkType Advanced
Passed=103
Failed=1
Skipped=7
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
* test_routers_network_ops.py
* test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failed
**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm
**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9182: Some running VMs turned ...
Posted by bvbharatk <gi...@git.apache.org>.
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1252#issuecomment-209286654
### ACS CI BVT Run
**Sumarry:**
Build Number 172
Hypervisor xenserver
NetworkType Advanced
Passed=18
Failed=63
Skipped=3
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
* test_deploy_vm_with_userdata.py
* ContextSuite context=TestDeployVmWithUserData>:setup Failed
* test_affinity_groups_projects.py
* ContextSuite context=TestDeployVmWithAffinityGroup>:setup Failed
* test_vpc_vpn.py
* ContextSuite context=TestVpcRemoteAccessVpn>:setup Failing since 4 runs
* ContextSuite context=TestVpcSite2SiteVpn>:setup Failing since 2 runs
* test_vpc_router_nics.py
* ContextSuite context=TestVPCNics>:setup Failed
* test_vm_snapshots.py
* ContextSuite context=TestSnapshots>:setup Failed
* ContextSuite context=TestVmSnapshot>:setup Failed
* test_vpc_redundant.py
* ContextSuite context=TestVPCRedundancy>:setup Failed
* test_privategw_acl.py
* ContextSuite context=TestPrivateGwACL>:setup Failed
* test_scale_vm.py
* ContextSuite context=TestScaleVm>:setup Failing since 3 runs
* test_router_dhcphosts.py
* ContextSuite context=TestRouterDHCPHosts>:setup Failed
* test_routers_iptables_default_policy.py
* ContextSuite context=TestRouterIpTablesPolicies>:setup Failed
* ContextSuite context=TestVPCIpTablesPolicies>:setup Failed
* test_quota.py
* test_01_quota Failing since 2 runs
* test_02_quota Failing since 2 runs
* test_03_quota Failing since 2 runs
* test_04_quota Failing since 2 runs
* test_05_quota Failing since 2 runs
* test_06_quota Failing since 2 runs
* test_07_quota Failing since 2 runs
* test_loadbalance.py
* ContextSuite context=TestLoadBalance>:setup Failed
* test_routers.py
* ContextSuite context=TestRouterServices>:setup Failed
* test_snapshots.py
* ContextSuite context=TestSnapshotRootDisk>:setup Failed
* test_deploy_vms_with_varied_deploymentplanners.py
* ContextSuite context=TestDeployVmWithVariedPlanners>:setup Failed
* test_network.py
* test_delete_account Failed
* ContextSuite context=TestPortForwarding>:setup Failed
* test_public_ip_admin_account Failed
* test_reboot_router Failed
* test_releaseIP Failed
* ContextSuite context=TestRouterRules>:setup Failed
* test_deploy_vm_iso.py
* test_deploy_vm_from_iso Failed
* test_multipleips_per_nic.py
* test_nic_secondaryip_add_remove Failed
* test_affinity_groups.py
* ContextSuite context=TestDeployVmWithAffinityGroup>:setup Failing since 2 runs
* test_network_acl.py
* ContextSuite context=TestNetworkACL>:setup Failed
* test_volumes.py
* ContextSuite context=TestCreateVolume>:setup Failed
* ContextSuite context=TestVolumes>:setup Failed
* test_ssvm.py
* test_01_list_sec_storage_vm Failed
* test_02_list_cpvm_vm Failed
* test_03_ssvm_internals Failed
* test_04_cpvm_internals Failed
* test_05_stop_ssvm Failed
* test_06_stop_cpvm Failed
* test_07_reboot_ssvm Failed
* test_08_reboot_cpvm Failed
* test_09_destroy_ssvm Failed
* test_10_destroy_cpvm Failed
* test_internal_lb.py
* ContextSuite context=TestInternalLb>:setup Failed
* test_nic.py
* test_01_nic Failed
* test_deploy_vm_root_resize.py
* test_00_deploy_vm_root_resize Failed
* test_01_deploy_vm_root_resize Failed
* test_02_deploy_vm_root_resize Failed
* test_secondary_storage.py
* test_01_sys_vm_start Failed
* test_02_sys_template_ready Failed
* test_password_server.py
* ContextSuite context=TestIsolatedNetworksPasswdServer>:setup Failed
* test_vm_life_cycle.py
* ContextSuite context=TestVMLifeCycle>:setup Failed
* test_routers_network_ops.py
* test_01_isolate_network_FW_PF_default_routes_egress_true Failing since 2 runs
* test_02_isolate_network_FW_PF_default_routes_egress_false Failed
* test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 2 runs
* test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 2 runs
* test_03_RVR_Network_check_router_state Failed
* test_templates.py
* ContextSuite context=TestTemplates>:setup Failed
* test_iso.py
* test_01_create_iso Failed
* ContextSuite context=TestISO>:setup Failed
**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_deploy_vgpu_enabled_vm
ContextSuite context=TestCreateTemplate>:setup
**Passed test suits:**
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_guest_vlan_range.py
test_non_contigiousvlan.py
test_public_ip_range.py
test_regions.py
test_pvlan.py
test_resource_detail.py
test_disk_offerings.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1252: CLOUDSTACK-9182: Some running VMs turned off on manu...
Posted by cloudmonger <gi...@git.apache.org>.
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/1252
### ACS CI BVT Run
**Sumarry:**
Build Number 530
Hypervisor xenserver
NetworkType Advanced
Passed=110
Failed=2
Skipped=7
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
* test_routers_network_ops.py
* test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 3 runs
* test_03_RVR_Network_check_router_state Failed
**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm
**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_metrics_api.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1252: CLOUDSTACK-9182: Some running VMs turned off on manu...
Posted by cloudmonger <gi...@git.apache.org>.
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/1252
### ACS CI BVT Run
**Sumarry:**
Build Number 532
Hypervisor xenserver
NetworkType Advanced
Passed=110
Failed=2
Skipped=7
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
* test_vm_snapshots.py
* test_change_service_offering_for_vm_with_snapshots Failed
* test_routers_network_ops.py
* test_03_RVR_Network_check_router_state Failed
**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm
**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_metrics_api.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1252: CLOUDSTACK-9182: Some running VMs turned off on manu...
Posted by cloudmonger <gi...@git.apache.org>.
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/1252
### ACS CI BVT Run
**Sumarry:**
Build Number 153
Hypervisor xenserver
NetworkType Advanced
Passed=101
Failed=4
Skipped=7
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
* test_snapshots.py
* test_01_snapshot_root_disk Failed
* test_deploy_vm_iso.py
* test_deploy_vm_from_iso Failing since 25 runs
* test_affinity_groups.py
* test_DeployVmAntiAffinityGroup Failed
* test_vm_life_cycle.py
* test_10_attachAndDetach_iso Failing since 26 runs
**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm
**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_routers_network_ops.py
test_disk_offerings.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1252: CLOUDSTACK-9182: Some running VMs turned off on manu...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1252
@sureshanaparti thanks, do you think this would be useful for 4.9? Can you change the PR's base branch to 4.9, rebase your branch against 4.9, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1252: CLOUDSTACK-9182: Some running VMs turned off on manu...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1252
@sureshanaparti is there an existing marvin test for this, or if you can add one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9182: Some running VMs turned ...
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1252#issuecomment-215327572
@sureshanaparti There are some comments, please address them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1252: CLOUDSTACK-9182: Some running VMs turned off on manu...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1252
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-315
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1252: CLOUDSTACK-9182: Some running VMs turned off on manu...
Posted by sureshanaparti <gi...@git.apache.org>.
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1252
@rhtyd Addressed the changes suggested and rebased against latest master. Tested this manually.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1252: CLOUDSTACK-9182: Some running VMs turned off on manu...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1252
Trillian queue is full, I'll kick tests tonight.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9182: Some running VMs turned ...
Posted by pedro-martins <gi...@git.apache.org>.
Github user pedro-martins commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1252#discussion_r53579947
--- Diff: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -1472,6 +1473,12 @@ private void advanceStop(final VMInstanceVO vm, final boolean cleanUpEvenIfUnabl
_workDao.update(work.getId(), work);
}
return;
+ } else {
+ HostVO host = _hostDao.findById(hostId);
+ if (!cleanUpEvenIfUnableToStop && vm.getState() == State.Running && host.getResourceState() == ResourceState.PrepareForMaintenance) {
+ s_logger.debug("Host in PrepareForMaintenance state - Failed to stop VM with id: " + vm.getId());
--- End diff --
hello @sureshanaparti.
How about you extract the content in the 'if' at line 1478 to an "isHostPreparingForMaintenance" method or something like that? it will explain better the if content, and you can do a test case to this method too
Ty.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1252: CLOUDSTACK-9182: Some running VMs turned off on manu...
Posted by sureshanaparti <gi...@git.apache.org>.
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/1252
@rhtyd no existing marvin test for this. will add the test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9182: Some running VMs turned ...
Posted by rodrigo93 <gi...@git.apache.org>.
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1252#issuecomment-170130323
Did someone tested it? This can be very handy.
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1252: CLOUDSTACK-9182: Some running VMs turned off on manu...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1252
Thanks @sureshanaparti
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---