[GitHub] [pulsar] nodece commented on a diff in pull request #20435: [fix][build] Fix the pulsar-all image may use the wrong upstream image

["nodece (via GitHub)" <gi...@apache.org>]

nodece commented on code in PR #20435:
URL: https://github.com/apache/pulsar/pull/20435#discussion_r1209790086


##########
docker/pulsar-all/Dockerfile:
##########
@@ -26,6 +27,6 @@ ADD ${PULSAR_IO_DIR} /connectors
 ADD ${PULSAR_OFFLOADER_TARBALL} /
 RUN mv /apache-pulsar-offloaders-*/offloaders /offloaders
 
-FROM apachepulsar/pulsar:latest
+FROM $PULSAR_IMAGE

Review Comment:
   ```suggestion
   ARG PULSAR_IMAGE
   FROM $PULSAR_IMAGE
   ```



##########
docker/pulsar-all/Dockerfile:
##########
@@ -17,6 +17,7 @@
 # under the License.
 #
 
+ARG PULSAR_IMAGE

Review Comment:
   ```suggestion
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org