You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by yuri1969 <gi...@git.apache.org> on 2017/08/18 18:01:39 UTC

[GitHub] nifi pull request #2100: NIFI-2715 - When performing a Queue Listing, if...

GitHub user yuri1969 opened a pull request:

    https://github.com/apache/nifi/pull/2100

    NIFI-2715 - When performing a Queue Listing, if...

    ...FlowFile has no content, UI does not indicate this fact
    
    For FlowFiles with no content:
    * Added a simple title replacing the Content Claim's one.
    * Defaulted File Size to 0 bytes using common formatting.
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yuri1969/nifi NIFI-2715

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2100.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2100
    
----
commit 24fbffbedb7d264af61918f931742278d124e41d
Author: yuri1969 <19...@gmail.com>
Date:   2017-08-16T20:42:08Z

    NIFI-2715 - When performing a Queue Listing, if...
    
    ...FlowFile has no content, UI does not indicate this fact
    
    For FlowFiles with no content:
    * Added a simple title replacing the Content Claim's one.
    * Defaulted File Size to 0 bytes using common formatting.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #2100: NIFI-2715 - When performing a Queue Listing, if...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/2100


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #2100: NIFI-2715 - When performing a Queue Listing, if...

Posted by scottyaslan <gi...@git.apache.org>.
Github user scottyaslan commented on the issue:

    https://github.com/apache/nifi/pull/2100
  
    @yuri1969 there are still a few style issues with the 'No Content Available' text. It seems you are incorrectly applying a font-size of 12px when it should be 13px. Also, you are applying a 'Roboto-Slab' font to the text when it should only be 'Roboto'. Let me know when you have updated this PR and I will review it again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #2100: NIFI-2715 - When performing a Queue Listing, if...

Posted by scottyaslan <gi...@git.apache.org>.
Github user scottyaslan commented on the issue:

    https://github.com/apache/nifi/pull/2100
  
    @yuri1969 this is looking good however I have a few comments: For the case where the FF has no size the text 'No Content Available' is good but we should keep the .flowfile-header 'Content Claim' visible and move the text 'No Content Available' below that header and give it an .unset css class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #2100: NIFI-2715 - When performing a Queue Listing, if...

Posted by yuri1969 <gi...@git.apache.org>.
Github user yuri1969 commented on the issue:

    https://github.com/apache/nifi/pull/2100
  
    @scottyaslan The text's style should match the one used on detail values now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #2100: NIFI-2715 - When performing a Queue Listing, if...

Posted by scottyaslan <gi...@git.apache.org>.
Github user scottyaslan commented on the issue:

    https://github.com/apache/nifi/pull/2100
  
    Reviewing....


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---