You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/07/19 07:26:39 UTC

[GitHub] [skywalking] stalary opened a new pull request #5126: Support jvm_thread metrics

stalary opened a new pull request #5126:
URL: https://github.com/apache/skywalking/pull/5126


   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   - [x] New feature provided
   - [ ] Improve performance
   
   - Related issues
   https://github.com/apache/skywalking/issues/5098
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   Support jvm_thread metrics


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #5126: Support jvm_thread metrics

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #5126:
URL: https://github.com/apache/skywalking/pull/5126#issuecomment-660641321


   Read the doc about `git submodule`. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] stalary commented on pull request #5126: Support jvm_thread metrics

Posted by GitBox <gi...@apache.org>.
stalary commented on pull request #5126:
URL: https://github.com/apache/skywalking/pull/5126#issuecomment-660601911


   PTAL @ascrutae 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] stalary commented on pull request #5126: Support jvm_thread metrics

Posted by GitBox <gi...@apache.org>.
stalary commented on pull request #5126:
URL: https://github.com/apache/skywalking/pull/5126#issuecomment-660650445


   ![截屏2020-07-19 下午10 16 46](https://user-images.githubusercontent.com/24592373/87876896-9b78eb00-ca0d-11ea-93fe-1c114aedc9b4.png)
   How can I solve this problem?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] stalary closed pull request #5126: Support jvm_thread metrics

Posted by GitBox <gi...@apache.org>.
stalary closed pull request #5126:
URL: https://github.com/apache/skywalking/pull/5126


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] stalary commented on pull request #5126: Support jvm_thread metrics

Posted by GitBox <gi...@apache.org>.
stalary commented on pull request #5126:
URL: https://github.com/apache/skywalking/pull/5126#issuecomment-660661552


   > I think this is only related to your local git submodule issue. If you are not familiar with the commands, try Sourcetree, it is very friendly to the git submodule with providing a GUI.
   
   thanks, 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] stalary commented on pull request #5126: Support jvm_thread metrics

Posted by GitBox <gi...@apache.org>.
stalary commented on pull request #5126:
URL: https://github.com/apache/skywalking/pull/5126#issuecomment-660641813


   > Take a look at `ui-initialized-templates.yml`, you should add new components on the instance page, then export the new dashboard configurations, and update this file.
   > 
   > This file managed the default UI layout since 8.0.0. You should have used it, right?
   
   ok, I missed it here


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] stalary removed a comment on pull request #5126: Support jvm_thread metrics

Posted by GitBox <gi...@apache.org>.
stalary removed a comment on pull request #5126:
URL: https://github.com/apache/skywalking/pull/5126#issuecomment-660602774


   https://github.com/apache/skywalking-data-collect-protocol/blob/24788cf41807048dcbe8dba0958688aaaf630d73/language-agent/JVMMetric.proto


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] stalary edited a comment on pull request #5126: Support jvm_thread metrics

Posted by GitBox <gi...@apache.org>.
stalary edited a comment on pull request #5126:
URL: https://github.com/apache/skywalking/pull/5126#issuecomment-660602833


   How do I update this file? I can't update it with Git. @wu-sheng 
   https://github.com/apache/skywalking-data-collect-protocol/blob/24788cf41807048dcbe8dba0958688aaaf630d73/language-agent/JVMMetric.proto


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #5126: Support jvm_thread metrics

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #5126:
URL: https://github.com/apache/skywalking/pull/5126#issuecomment-660651735


   I think this is only related to your local git submodule issue. If you are not familiar with the commands, try Sourcetree, it is very friendly to the git submodule with providing a GUI.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] stalary commented on pull request #5126: Support jvm_thread metrics

Posted by GitBox <gi...@apache.org>.
stalary commented on pull request #5126:
URL: https://github.com/apache/skywalking/pull/5126#issuecomment-660602833


   How do I update this file? I can't update it with Git
   https://github.com/apache/skywalking-data-collect-protocol/blob/24788cf41807048dcbe8dba0958688aaaf630d73/language-agent/JVMMetric.proto


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] stalary commented on pull request #5126: Support jvm_thread metrics

Posted by GitBox <gi...@apache.org>.
stalary commented on pull request #5126:
URL: https://github.com/apache/skywalking/pull/5126#issuecomment-660602774


   https://github.com/apache/skywalking-data-collect-protocol/blob/24788cf41807048dcbe8dba0958688aaaf630d73/language-agent/JVMMetric.proto


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org