You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "warren830 (via GitHub)" <gi...@apache.org> on 2023/02/22 07:18:13 UTC
[GitHub] [incubator-devlake] warren830 opened a new pull request, #4484: feat(sonarqube): change field type and add unit test
warren830 opened a new pull request, #4484:
URL: https://github.com/apache/incubator-devlake/pull/4484
### Summary
As we need to calculate issues.debt and effort, we need to set these fields to int
### Does this close any open issues?
part of #2305
### Screenshots
<img width="148" alt="image" src="https://user-images.githubusercontent.com/39366025/220549890-71dc9dc6-7ece-453c-bf59-562d9e6351d2.png">
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] abeizn merged pull request #4484: feat(sonarqube): change field type and add unit test
Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn merged PR #4484:
URL: https://github.com/apache/incubator-devlake/pull/4484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] abeizn commented on a diff in pull request #4484: feat(sonarqube): change field type and add unit test
Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn commented on code in PR #4484:
URL: https://github.com/apache/incubator-devlake/pull/4484#discussion_r1114099330
##########
backend/core/models/migrationscripts/20230208_add_code_quality.go:
##########
@@ -27,6 +27,15 @@ import (
type addCodeQuality struct{}
func (u *addCodeQuality) Up(basicRes context.BasicRes) errors.Error {
+ err := basicRes.GetDal().DropTables(
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] abeizn commented on a diff in pull request #4484: feat(sonarqube): change field type and add unit test
Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn commented on code in PR #4484:
URL: https://github.com/apache/incubator-devlake/pull/4484#discussion_r1114096954
##########
backend/plugins/sonarqube/models/migrationscripts/20230111_add_init_tables.go:
##########
@@ -27,6 +27,17 @@ import (
type addInitTables struct{}
func (*addInitTables) Up(basicRes context.BasicRes) errors.Error {
+ err := basicRes.GetDal().DropTables(
Review Comment:
why drop tables?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] abeizn commented on a diff in pull request #4484: feat(sonarqube): change field type and add unit test
Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn commented on code in PR #4484:
URL: https://github.com/apache/incubator-devlake/pull/4484#discussion_r1114087610
##########
backend/plugins/sonarqube/models/migrationscripts/20230111_add_init_tables.go:
##########
@@ -40,7 +51,7 @@ func (*addInitTables) Up(basicRes context.BasicRes) errors.Error {
}
func (*addInitTables) Version() uint64 {
- return 20230208220025
Review Comment:
we need migrate？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org