You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/16 05:13:28 UTC

[GitHub] [skywalking-cli] Tom-DaLin opened a new pull request #108: Completion

Tom-DaLin opened a new pull request #108:
URL: https://github.com/apache/skywalking-cli/pull/108


   This PR adds auto-completion to bash and powershell.
   
   If you are using bash, you can get all matching command by pressing Tab twice:
   
   ![bash](https://user-images.githubusercontent.com/52828870/129514071-24aeffb4-40c0-4368-a651-f1c676010016.gif)
   
   And if you are using powershell, every time you press Tab, you will get a matching command, for example:
   
   ![powershell](https://user-images.githubusercontent.com/52828870/129514047-724f84e8-c280-4b1b-b44b-9efcfb8d1e19.gif)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-cli] fgksgf merged pull request #108: Support auto-completion for bash and powershell

Posted by GitBox <gi...@apache.org>.
fgksgf merged pull request #108:
URL: https://github.com/apache/skywalking-cli/pull/108


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-cli] fgksgf commented on pull request #108: Completion

Posted by GitBox <gi...@apache.org>.
fgksgf commented on pull request #108:
URL: https://github.com/apache/skywalking-cli/pull/108#issuecomment-899247067


   @Tom-DaLin  Resolve conflicts, please 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-cli] codecov-commenter commented on pull request #108: Completion

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #108:
URL: https://github.com/apache/skywalking-cli/pull/108#issuecomment-899221138


   # [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/108?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#108](https://codecov.io/gh/apache/skywalking-cli/pull/108?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (83be295) into [master](https://codecov.io/gh/apache/skywalking-cli/commit/0494541890cd44a9be23e7fe091f9d0f84986613?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0494541) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking-cli/pull/108/graphs/tree.svg?width=650&height=150&src=pr&token=oivudZDTNJ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking-cli/pull/108?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #108   +/-   ##
   =======================================
     Coverage   44.62%   44.62%           
   =======================================
     Files          15       15           
     Lines         251      251           
   =======================================
     Hits          112      112           
     Misses        131      131           
     Partials        8        8           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/108?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/108?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0494541...83be295](https://codecov.io/gh/apache/skywalking-cli/pull/108?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-cli] fgksgf commented on a change in pull request #108: Completion

Posted by GitBox <gi...@apache.org>.
fgksgf commented on a change in pull request #108:
URL: https://github.com/apache/skywalking-cli/pull/108#discussion_r689246371



##########
File path: internal/commands/completion/completion.go
##########
@@ -0,0 +1,31 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package completion
+
+import (
+	"github.com/urfave/cli"
+)
+
+var Command = cli.Command{
+	Name:  "completion",
+	Usage: "Output shell completion code for bash, zsh or powershell",

Review comment:
       No zsh for now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-cli] fgksgf commented on a change in pull request #108: Completion

Posted by GitBox <gi...@apache.org>.
fgksgf commented on a change in pull request #108:
URL: https://github.com/apache/skywalking-cli/pull/108#discussion_r689258159



##########
File path: internal/commands/completion/completion.go
##########
@@ -0,0 +1,31 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package completion
+
+import (
+	"github.com/urfave/cli"
+)
+
+var Command = cli.Command{
+	Name:  "completion",
+	Usage: "Output shell completion code for bash, zsh or powershell",

Review comment:
       ```suggestion
   	Usage: "Output shell completion code for bash and powershell",
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org