You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/12 11:54:30 UTC

[GitHub] [flink] astamur commented on a diff in pull request #21407: [FLINK-30224][Connectors/Kinesis] An IT test for slow FlinKinesisConsumer's run() which caused an NPE in close

astamur commented on code in PR #21407:
URL: https://github.com/apache/flink/pull/21407#discussion_r1045731622


##########
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisITCase.java:
##########
@@ -175,6 +184,40 @@ private void testStopWithSavepoint(boolean drain, boolean efo) throws Exception
         }
     }
 
+    /**
+     * Tests stop with savepoint while {@link
+     * FlinkKinesisConsumer#run(SourceFunction.SourceContext)}} with a slow run method is still
+     * hasn't finished run method and hasn't set a {@link KinesisDataFetcher} yet.
+     */

Review Comment:
   Done. Thank you.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org