You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/17 11:24:22 UTC

[GitHub] [airflow] uranusjr commented on pull request #19639: Remove `allowed_conn_types` from SqlSensor

uranusjr commented on pull request #19639:
URL: https://github.com/apache/airflow/pull/19639#issuecomment-971483609


   Oh no the test suite doesn’t like this
   
   ```
   tests/sensors/test_sql_sensor.py::TestSqlSensor::test_sql_sensor_postgres_poke: airflow.exceptions.AirflowException: The connection type is not supported by SqlSensor. The associated hook should be a subclass of `DbApiHook`. Got MagicMock
   tests/sensors/test_sql_sensor.py::TestSqlSensor::test_sql_sensor_postgres_poke_failure: airflow.exceptions.AirflowException: The connection type is not supported by SqlSensor. The associated hook should be a subclass of `DbApiHook`. Got MagicMock
   tests/sensors/test_sql_sensor.py::TestSqlSensor::test_sql_sensor_postgres_poke_failure_success: airflow.exceptions.AirflowException: The connection type is not supported by SqlSensor. The associated hook should be a subclass of `DbApiHook`. Got MagicMock
   tests/sensors/test_sql_sensor.py::TestSqlSensor::test_sql_sensor_postgres_poke_failure_success_same: airflow.exceptions.AirflowException: The connection type is not supported by SqlSensor. The associated hook should be a subclass of `DbApiHook`. Got MagicMock
   tests/sensors/test_sql_sensor.py::TestSqlSensor::test_sql_sensor_postgres_poke_invalid_failure: AssertionError: assert 'self.failure...llable -> [1]' == 'The connecti...Got MagicMock'
     - The connection type is not supported by SqlSensor. The associated hook should be a subclass of `DbApiHook`. Got MagicMock
     + self.failure is present, but not callable -> [1]
   tests/sensors/test_sql_sensor.py::TestSqlSensor::test_sql_sensor_postgres_poke_invalid_success: AssertionError: assert 'self.success...llable -> [1]' == 'The connecti...Got MagicMock'
     - The connection type is not supported by SqlSensor. The associated hook should be a subclass of `DbApiHook`. Got MagicMock
     + self.success is present, but not callable -> [1]
   tests/sensors/test_sql_sensor.py::TestSqlSensor::test_sql_sensor_postgres_poke_success: airflow.exceptions.AirflowException: The connection type is not supported by SqlSensor. The associated hook should be a subclass of `DbApiHook`. Got MagicMock
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org