[GitHub] [phoenix-omid] richardantal commented on a diff in pull request #109: OMID-223 Refactor Omid to use HBase 2 APIs internally.

[GitBox <gi...@apache.org>]

richardantal commented on code in PR #109:
URL: https://github.com/apache/phoenix-omid/pull/109#discussion_r937688092


##########
common/src/main/java/org/apache/omid/YAMLUtils.java:
##########
@@ -64,7 +64,6 @@ public Map loadSettings(String resourcePath, String defaultResourcePath) throws
         return defaultSetting;
     }
 
-    @SuppressWarnings("unchecked")

Review Comment:
   Why don't we remove the @SuppressWarnings("unchecked") from line number 56?
   Maybe @stoty knows it better.



##########
pom.xml:
##########
@@ -158,7 +158,7 @@
         <phoenix.thirdparty.version>2.0.0</phoenix.thirdparty.version>
         <guice.version>3.0</guice.version>
         <testng.version>6.10</testng.version>
-        <slf4j.version>1.7.36</slf4j.version>
+        <slf4j.version>1.7.30</slf4j.version>

Review Comment:
   I guess it is an unintentional change during rebase



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org