You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/09 08:43:19 UTC
[GitHub] [apisix] membphis commented on a change in pull request #2970: feat: add metric for batch process entries
membphis commented on a change in pull request #2970:
URL: https://github.com/apache/apisix/pull/2970#discussion_r539112772
##########
File path: apisix/plugins/http-logger.lua
##########
@@ -277,7 +277,8 @@ function _M.log(conf, ctx)
max_retry_count = conf.max_retry_count,
buffer_duration = conf.buffer_duration,
inactive_timeout = conf.inactive_timeout,
- route_id = ctx.route_id
+ route_id = ctx.route_id,
+ server_addr = ctx.var["server_addr"]
Review comment:
code style, we should always add a `,` here.
example:
```lua
route_id = ctx.route_id,
server_addr = ctx.var["server_addr"],
##########
File path: apisix/plugins/http-logger.lua
##########
@@ -277,7 +277,8 @@ function _M.log(conf, ctx)
max_retry_count = conf.max_retry_count,
buffer_duration = conf.buffer_duration,
inactive_timeout = conf.inactive_timeout,
- route_id = ctx.route_id
+ route_id = ctx.route_id,
+ server_addr = ctx.var["server_addr"]
Review comment:
and please fix similar points
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org