You are viewing a plain text version of this content. The canonical link for it is here.
Posted to rivet-dev@tcl.apache.org by Georgios Petasis <pe...@apache.org> on 2019/02/16 20:55:47 UTC

Generating artifacts in AppVeyor...

Dear Massimo (and all),

I have modified .appveyor.yml in master branch, to generate artifacts. 
Currently, a zip file is generated, that contains both the module .so 
library, and the rivet tcl library. You can see the generated artifacts 
if you go to the last build (by following the badges in the github page 
https://github.com/apache/tcl-rivet), and checking the "Artifacts" tab 
of each build.

For example here:

https://ci.appveyor.com/project/petasis/tcl-rivet/build/job/xxfwh9vg6ew5dlck/artifacts

I have also placed the needed code that will upload the artifacts to the 
github release, if a tag is added (in any branch).

I have not yet made a test for that. It may fail if the access token 
(which is mine for tkdnd) will not work for rivet. We will see when the 
first tag is added :-)

And we need to change the badges, to show the AppVeyor build of the 
Apache user.

Best,

George


---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org


Re: Generating artifacts in AppVeyor...

Posted by Massimo Manghi <ma...@alice.it>.
I tagged the commit from which 3.1.1 was released and pushed the tag 
yesterday.

  -- Massimo

On 2/20/19 8:26 PM, Georgios Petasis wrote:
> Στις 18/2/2019 18:14, ο Massimo Manghi έγραψε:
>> On 2/17/19 9:34 PM, Georgios Petasis wrote:
>>>
>>> Yes. The artifacts will be generated with every commit. They will get 
>>> deployed in github with every tag added.
>>>
>>> (If my credentials work of course).
>>>
>>> Best,
>>>
>>> George
>>>
>>
>> I just realized that we haven't pushed the 3.1.1 tag to gitbox and 
>> github didn't create a release out of it. Actually a thread is going 
>> on on @members where people are correctly warning PMCs not to release 
>> through this mechanism unless a vote took place. Therefore as per 
>> bylaws we are entitled to release in this way but I wonder how 3.1.0 
>> got into the releases page 
>> https://github.com/apache/tcl-rivet/releases if we didn't explicitly 
>> connect the tag to the release...
>>
>>  -- Massimo
>>
> I am not sure I understand. Both 3.1.0 and 3.1.1 exist as tags in our 
> repository. And I can see both as releases in github.
> 
> Are these releases created by you? Or automatically by github?
> 
> George
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
> For additional commands, e-mail: rivet-dev-help@tcl.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org


Re: Generating artifacts in AppVeyor...

Posted by Georgios Petasis <pe...@apache.org>.
Στις 18/2/2019 18:14, ο Massimo Manghi έγραψε:
> On 2/17/19 9:34 PM, Georgios Petasis wrote:
>>
>> Yes. The artifacts will be generated with every commit. They will get 
>> deployed in github with every tag added.
>>
>> (If my credentials work of course).
>>
>> Best,
>>
>> George
>>
>
> I just realized that we haven't pushed the 3.1.1 tag to gitbox and 
> github didn't create a release out of it. Actually a thread is going 
> on on @members where people are correctly warning PMCs not to release 
> through this mechanism unless a vote took place. Therefore as per 
> bylaws we are entitled to release in this way but I wonder how 3.1.0 
> got into the releases page 
> https://github.com/apache/tcl-rivet/releases if we didn't explicitly 
> connect the tag to the release...
>
>  -- Massimo
>
I am not sure I understand. Both 3.1.0 and 3.1.1 exist as tags in our 
repository. And I can see both as releases in github.

Are these releases created by you? Or automatically by github?

George


---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org


Re: Generating artifacts in AppVeyor...

Posted by Massimo Manghi <ma...@alice.it>.
On 2/17/19 9:34 PM, Georgios Petasis wrote:
> 
> Yes. The artifacts will be generated with every commit. They will get 
> deployed in github with every tag added.
> 
> (If my credentials work of course).
> 
> Best,
> 
> George
> 

I just realized that we haven't pushed the 3.1.1 tag to gitbox and 
github didn't create a release out of it. Actually a thread is going on 
on @members where people are correctly warning PMCs not to release 
through this mechanism unless a vote took place. Therefore as per bylaws 
we are entitled to release in this way but I wonder how 3.1.0 got into 
the releases page https://github.com/apache/tcl-rivet/releases if we 
didn't explicitly connect the tag to the release...

  -- Massimo

---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org


Re: Generating artifacts in AppVeyor...

Posted by Georgios Petasis <pe...@apache.org>.
Στις 17/2/2019 17:47, ο Massimo MANGHI έγραψε:
> Hi George
>
> On 2/16/19 9:55 PM, Georgios Petasis wrote:
>> Dear Massimo (and all),
>>
>> I have modified .appveyor.yml in master branch, to generate artifacts.
>> Currently, a zip file is generated, that contains both the module .so
>> library, and the rivet tcl library. You can see the generated artifacts
>> if you go to the last build (by following the badges in the github page
>> https://github.com/apache/tcl-rivet), and checking the "Artifacts" tab
>> of each build.
>>
>> For example here:
>>
>> https://ci.appveyor.com/project/petasis/tcl-rivet/build/job/xxfwh9vg6ew5dlck/artifacts
>>
>>   > I have also placed the needed code that will upload the artifacts to the
>> github release, if a tag is added (in any branch).
> thank you! Well done
>
>    This is building a 3.2 which is formally unreleased (actually it's
> very close to 3.1.1) So if we made a mock 3.1.2 release by adding a tag
> to 3.1 that would trigger an artifact build?
I think yes. It will also attempt to deploy it to github, if a tag is 
added (as a draft pre-release).
>   I guess we have to copy the
> current .appveyor.yml file from master.

Yes. The artifacts will be generated with every commit. They will get 
deployed in github with every tag added.

(If my credentials work of course).

Best,

George


---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org


Re: Generating artifacts in AppVeyor...

Posted by Massimo MANGHI <ma...@unipr.it>.
Hi George

On 2/16/19 9:55 PM, Georgios Petasis wrote:
> Dear Massimo (and all),
> 
> I have modified .appveyor.yml in master branch, to generate artifacts. 
> Currently, a zip file is generated, that contains both the module .so 
> library, and the rivet tcl library. You can see the generated artifacts 
> if you go to the last build (by following the badges in the github page 
> https://github.com/apache/tcl-rivet), and checking the "Artifacts" tab 
> of each build.
> 
> For example here:
> 
> https://ci.appveyor.com/project/petasis/tcl-rivet/build/job/xxfwh9vg6ew5dlck/artifacts 
> 
>  > I have also placed the needed code that will upload the artifacts to the
> github release, if a tag is added (in any branch).

thank you! Well done

  This is building a 3.2 which is formally unreleased (actually it's 
very close to 3.1.1) So if we made a mock 3.1.2 release by adding a tag 
to 3.1 that would trigger an artifact build? I guess we have to copy the 
current .appveyor.yml file from master.

  -- Massimo