You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by br...@apache.org on 2019/12/23 05:27:38 UTC

[cordova-windows] 01/02: add windows8.1 appxmanifest TODO comments

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a commit to branch brodybits-uwp-only-test-wip0610
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git

commit 4ebfb89f21ddd982e9d88b28bc102a7ca402f02f
Author: Christopher J. Brody <ch...@brody.consulting>
AuthorDate: Mon Dec 23 00:26:27 2019 -0500

    add windows8.1 appxmanifest TODO comments
---
 bin/lib/update.js                    | 1 +
 template/cordova/lib/AppxManifest.js | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/bin/lib/update.js b/bin/lib/update.js
index 2372703..5ef2ab9 100644
--- a/bin/lib/update.js
+++ b/bin/lib/update.js
@@ -43,6 +43,7 @@ module.exports.update = function (destinationDir, options) {
     var guid;
     var config = new ConfigParser(projectConfig);
 
+    // TODO find a better way to handle the guid than the old WP 8.1 appxmanifest (!!)
     // guid param is used only when adding a platform, and isn't saved anywhere.
     // The only place, where it is being persisted - phone/win10 appxmanifest file,
     // but since win10 introduced just recently, we can't rely on its manifest
diff --git a/template/cordova/lib/AppxManifest.js b/template/cordova/lib/AppxManifest.js
index b2b7e90..cf3f5c5 100644
--- a/template/cordova/lib/AppxManifest.js
+++ b/template/cordova/lib/AppxManifest.js
@@ -56,7 +56,9 @@ var MANIFESTS = {
     }
 };
 
+// TODO remove old Windows 8.1 & WP 8.1 appxmanifest files
 var SUBSTS = ['package.phone.appxmanifest', 'package.windows.appxmanifest', 'package.windows10.appxmanifest'];
+
 var TARGETS = ['windows', 'phone', 'all'];
 
 /**


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org