[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #10001: [Bug] runtime filter is not used as expected

[GitBox <gi...@apache.org>]

HappenLee commented on code in PR #10001:
URL: https://github.com/apache/incubator-doris/pull/10001#discussion_r891332695


##########
be/src/exec/olap_scan_node.cpp:
##########
@@ -1566,7 +1566,7 @@ void OlapScanNode::scanner_thread(OlapScanner* scanner) {
     auto& scanner_filter_apply_marks = *scanner->mutable_runtime_filter_marks();
     DCHECK(scanner_filter_apply_marks.size() == _runtime_filter_descs.size());
     for (size_t i = 0; i < scanner_filter_apply_marks.size(); i++) {
-        if (!scanner_filter_apply_marks[i] && !_runtime_filter_ctxs[i].apply_mark) {

Review Comment:
   should keep the  `!_runtime_filter_ctxs[i].apply_mark`.
   because if `runtime filter` come before 1s, the `apply_mark` is `true`, we do not need dispose the `runtime filter` already push down



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org