[GitHub] [nifi-registry] bbende commented on issue #169: NIFIREG-216 Add S3 BundlePersistenceProvider

[GitBox <gi...@apache.org>]

bbende commented on issue #169: NIFIREG-216 Add S3 BundlePersistenceProvider
URL: https://github.com/apache/nifi-registry/pull/169#issuecomment-485444846
 
 
   @kevdoran thanks for the review, I'm taking a look at your PR right now and will get it incorporated into this branch. Adding the URL option makes total sense and seems so obvious in hindsight.
   
   As far as the assembly/profile... I would be fine making the include-aws profile enabled by default, or documenting to enable the profile during releases. I started down the path of how the Ranger assembly was setup, but once I was done and looked at it, I started wondering whether the entire setup was really necessary and whether all the AWS stuff should just go in nifi-registry-framework. The only dependencies that may eventually need to be isolated seem like the jackson dependencies, since it could be possible that the AWS client at some point requires a different version than registry core. So I figured maybe it is still good to keep the structure for possible isolation down the road.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services