Re: svn commit: r169038 - /spamassassin/trunk/lib/Mail/SpamAssassin/Logger.pm

[Daniel Quinlan <qu...@pathname.com>]

jm@jmason.org (Justin Mason) writes:

> OK, can we discuss this?

Sure.  :-)
 
> what is the difference between info() and dbg() with this change?

info == stuff you probably want to log, but don't want to see
interactively most times

> is there a UI in spamd to enable info() output without dbg() messages?

Yes.  Right now, it's the default, the ||= line turns it on.

------- start of cut text --------------
# always turn on at least info-level debugging for spamd
$opt{'debug'} ||= 'info';
# turn on debugging facilities as soon as possible
Mail::SpamAssassin::Logger::add_facilities($opt{'debug'});
------- end ----------------------------

I've thought about actually removing the ||= line and then you'd need to
start spamd with "-D info" to get informational messages.

> is warn() still the only way to output if debug is off?  if so, what's
> the point of info() as it stands?

I'm not sure I understand the questions.  If dbg() is off, you can use
info() if info-level is on.

I've thought about adding a "notice()" level (between warn and info)
that would be used for stuff we want to log by default, then we'd set
notice on by default for spamd.  Then, people would enable info-level if
they want verbose logging.  notice-level would be more minimal and leave
out stuff like the child states and forking non-warning stuff.

Daniel

-- 
Daniel Quinlan
http://www.pathname.com/~quinlan/

Re: svn commit: r169038 - /spamassassin/trunk/lib/Mail/SpamAssassin/Logger.pm

[Theo Van Dinter <fe...@kluge.net>]

On Mon, May 09, 2005 at 12:25:23AM -0700, Justin Mason wrote:
> So why didn't this work for Theo?  Theo, are you using any
> setting for -D?

No.  In my case, there was no "-D" option passed at all.

> It turns out that it does seem to be working fine here for me; I get the
> "prefork: child states: " line from spamd OK with current SVN.  So
> Theo, I'd take another look...

I'll try it again in a little bit.  Right now, I've upgraded my box to 170072
and have debug mode enabled going out to a file.  If it locks up again, I'll
have that and I'll poke about with strace/lsof and see if there's something
obvious.

-- 
Randomly Generated Tagline:
Woo Hoo!  Good news everybody!  Because I endangered lives, we can fly 
 anywhere we want!
 
 		-- Homer Simpson
 		   Fear of Flying