You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "DL1231 (via GitHub)" <gi...@apache.org> on 2025/07/17 02:20:37 UTC
[PR] KAFKA-19509: Improve error message when release version is wrong [kafka]
DL1231 opened a new pull request, #20185:
URL: https://github.com/apache/kafka/pull/20185
Improve the error message in the kafka-storage.sh when an incorrect release-version is given.
Specifically, following the behavior of kafka-feature.sh, when an incorrect release-version is entered, it returns the currently supported versions to the user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19509: Improve error message when release version is wrong [kafka]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky commented on code in PR #20185:
URL: https://github.com/apache/kafka/pull/20185#discussion_r2224225489
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -128,9 +128,21 @@ object StorageTool extends Logging {
setIgnoreFormatted(namespace.getBoolean("ignore_formatted")).
setControllerListenerName(config.controllerListenerNames.get(0)).
setMetadataLogDirectory(config.metadataLogDir)
- Option(namespace.getString("release_version")).foreach(
- releaseVersion => formatter.
- setReleaseVersion(MetadataVersion.fromVersionString(releaseVersion)))
+
+ def metadataVersionsToString(first: MetadataVersion, last: MetadataVersion): String = {
+ val versions = MetadataVersion.VERSIONS.slice(first.ordinal, last.ordinal + 1)
+ versions.map(_.toString).mkString(", ")
+ }
+ Option(namespace.getString("release_version")).foreach(releaseVersion => {
+ try {
+ formatter.setReleaseVersion(MetadataVersion.fromVersionString(releaseVersion))
+ } catch {
+ case _: Throwable =>
+ throw new TerseFailure(s"Unknown metadata.version $releaseVersion. Supported metadata.version are " +
+ s"${metadataVersionsToString(MetadataVersion.MINIMUM_VERSION, MetadataVersion.latestProduction())}")
Review Comment:
Make sense.
The patch follows the pattern from `FeatureCommand`.
After adding a flag to `MetadataVersion.fromVersionString`, we should also update `FeatureCommand`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19509: Improve error message when release version is wrong [kafka]
Posted by "DL1231 (via GitHub)" <gi...@apache.org>.
DL1231 commented on code in PR #20185:
URL: https://github.com/apache/kafka/pull/20185#discussion_r2212566834
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -128,9 +128,22 @@ object StorageTool extends Logging {
setIgnoreFormatted(namespace.getBoolean("ignore_formatted")).
setControllerListenerName(config.controllerListenerNames.get(0)).
setMetadataLogDirectory(config.metadataLogDir)
- Option(namespace.getString("release_version")).foreach(
- releaseVersion => formatter.
- setReleaseVersion(MetadataVersion.fromVersionString(releaseVersion)))
+
+ def metadataVersionsToString(first: MetadataVersion, last: MetadataVersion): String = {
+ val versions = MetadataVersion.VERSIONS.slice(first.ordinal, last.ordinal + 1)
+ versions.map(_.toString).mkString(", ")
+ }
+ Option(namespace.getString("release_version")).foreach(releaseVersion => {
+ try {
+ formatter.setReleaseVersion(MetadataVersion.fromVersionString(releaseVersion))
+ } catch {
+ case _: Throwable =>
+ throw new TerseFailure("Unknown metadata.version " + releaseVersion +
+ ". Supported metadata.version are " + metadataVersionsToString(
+ MetadataVersion.MINIMUM_VERSION, MetadataVersion.latestProduction()))
+ }
Review Comment:
good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19509: Improve error message when release version is wrong [kafka]
Posted by "DL1231 (via GitHub)" <gi...@apache.org>.
DL1231 commented on code in PR #20185:
URL: https://github.com/apache/kafka/pull/20185#discussion_r2224215359
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -128,9 +128,21 @@ object StorageTool extends Logging {
setIgnoreFormatted(namespace.getBoolean("ignore_formatted")).
setControllerListenerName(config.controllerListenerNames.get(0)).
setMetadataLogDirectory(config.metadataLogDir)
- Option(namespace.getString("release_version")).foreach(
- releaseVersion => formatter.
- setReleaseVersion(MetadataVersion.fromVersionString(releaseVersion)))
+
+ def metadataVersionsToString(first: MetadataVersion, last: MetadataVersion): String = {
+ val versions = MetadataVersion.VERSIONS.slice(first.ordinal, last.ordinal + 1)
+ versions.map(_.toString).mkString(", ")
+ }
+ Option(namespace.getString("release_version")).foreach(releaseVersion => {
+ try {
+ formatter.setReleaseVersion(MetadataVersion.fromVersionString(releaseVersion))
+ } catch {
+ case _: Throwable =>
+ throw new TerseFailure(s"Unknown metadata.version $releaseVersion. Supported metadata.version are " +
+ s"${metadataVersionsToString(MetadataVersion.MINIMUM_VERSION, MetadataVersion.latestProduction())}")
Review Comment:
Good catch! Thanks for the review.
See the discussion:
https://github.com/apache/kafka/pull/18845#discussion_r1950706791
`MetadataVersion.fromVersionString` is just used to convert `String` to `MetadataVersion`. Perhaps the config `unstable.feature.versions.enable` shoule be considered when outputting error message. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19509: Improve error message when release version is wrong [kafka]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky merged PR #20185:
URL: https://github.com/apache/kafka/pull/20185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19509: Improve error message when release version is wrong [kafka]
Posted by "junrao (via GitHub)" <gi...@apache.org>.
junrao commented on code in PR #20185:
URL: https://github.com/apache/kafka/pull/20185#discussion_r2223756688
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -128,9 +128,21 @@ object StorageTool extends Logging {
setIgnoreFormatted(namespace.getBoolean("ignore_formatted")).
setControllerListenerName(config.controllerListenerNames.get(0)).
setMetadataLogDirectory(config.metadataLogDir)
- Option(namespace.getString("release_version")).foreach(
- releaseVersion => formatter.
- setReleaseVersion(MetadataVersion.fromVersionString(releaseVersion)))
+
+ def metadataVersionsToString(first: MetadataVersion, last: MetadataVersion): String = {
+ val versions = MetadataVersion.VERSIONS.slice(first.ordinal, last.ordinal + 1)
+ versions.map(_.toString).mkString(", ")
+ }
+ Option(namespace.getString("release_version")).foreach(releaseVersion => {
+ try {
+ formatter.setReleaseVersion(MetadataVersion.fromVersionString(releaseVersion))
+ } catch {
+ case _: Throwable =>
+ throw new TerseFailure(s"Unknown metadata.version $releaseVersion. Supported metadata.version are " +
+ s"${metadataVersionsToString(MetadataVersion.MINIMUM_VERSION, MetadataVersion.latestProduction())}")
Review Comment:
This is not very accurate. If the internal config unstable.feature.versions.enable is set, we actually allow non-production MVs. All callers of `MetadataVersion.fromVersionString` are either on the server side or from the tools and should have access to the unstable.feature.versions.enable. Perhaps it's better to change `MetadataVersion.fromVersionString` to take an enableUnstableFeature flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19509: Improve error message when release version is wrong [kafka]
Posted by "junrao (via GitHub)" <gi...@apache.org>.
junrao commented on code in PR #20185:
URL: https://github.com/apache/kafka/pull/20185#discussion_r2237138917
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -128,9 +128,21 @@ object StorageTool extends Logging {
setIgnoreFormatted(namespace.getBoolean("ignore_formatted")).
setControllerListenerName(config.controllerListenerNames.get(0)).
setMetadataLogDirectory(config.metadataLogDir)
- Option(namespace.getString("release_version")).foreach(
- releaseVersion => formatter.
- setReleaseVersion(MetadataVersion.fromVersionString(releaseVersion)))
+
+ def metadataVersionsToString(first: MetadataVersion, last: MetadataVersion): String = {
+ val versions = MetadataVersion.VERSIONS.slice(first.ordinal, last.ordinal + 1)
+ versions.map(_.toString).mkString(", ")
+ }
+ Option(namespace.getString("release_version")).foreach(releaseVersion => {
+ try {
+ formatter.setReleaseVersion(MetadataVersion.fromVersionString(releaseVersion))
+ } catch {
+ case _: Throwable =>
+ throw new TerseFailure(s"Unknown metadata.version $releaseVersion. Supported metadata.version are " +
+ s"${metadataVersionsToString(MetadataVersion.MINIMUM_VERSION, MetadataVersion.latestProduction())}")
Review Comment:
Ok. The tool is designed mainly for production usage. So, perhaps we could just leave it as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19509: Improve error message when release version is wrong [kafka]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky commented on PR #20185:
URL: https://github.com/apache/kafka/pull/20185#issuecomment-3083266340
@DL1231: Could you merge trunk?
The patch for failing tests has been merged into trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19509: Improve error message when release version is wrong [kafka]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky commented on code in PR #20185:
URL: https://github.com/apache/kafka/pull/20185#discussion_r2224225489
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -128,9 +128,21 @@ object StorageTool extends Logging {
setIgnoreFormatted(namespace.getBoolean("ignore_formatted")).
setControllerListenerName(config.controllerListenerNames.get(0)).
setMetadataLogDirectory(config.metadataLogDir)
- Option(namespace.getString("release_version")).foreach(
- releaseVersion => formatter.
- setReleaseVersion(MetadataVersion.fromVersionString(releaseVersion)))
+
+ def metadataVersionsToString(first: MetadataVersion, last: MetadataVersion): String = {
+ val versions = MetadataVersion.VERSIONS.slice(first.ordinal, last.ordinal + 1)
+ versions.map(_.toString).mkString(", ")
+ }
+ Option(namespace.getString("release_version")).foreach(releaseVersion => {
+ try {
+ formatter.setReleaseVersion(MetadataVersion.fromVersionString(releaseVersion))
+ } catch {
+ case _: Throwable =>
+ throw new TerseFailure(s"Unknown metadata.version $releaseVersion. Supported metadata.version are " +
+ s"${metadataVersionsToString(MetadataVersion.MINIMUM_VERSION, MetadataVersion.latestProduction())}")
Review Comment:
> Perhaps it's better to change MetadataVersion.fromVersionString to take an enableUnstableFeature flag.
Make sense.
The patch follows the pattern from `FeatureCommand`.
After adding a flag to `MetadataVersion.fromVersionString`, we should also update `FeatureCommand`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19509: Improve error message when release version is wrong [kafka]
Posted by "DL1231 (via GitHub)" <gi...@apache.org>.
DL1231 commented on code in PR #20185:
URL: https://github.com/apache/kafka/pull/20185#discussion_r2235304915
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -128,9 +128,21 @@ object StorageTool extends Logging {
setIgnoreFormatted(namespace.getBoolean("ignore_formatted")).
setControllerListenerName(config.controllerListenerNames.get(0)).
setMetadataLogDirectory(config.metadataLogDir)
- Option(namespace.getString("release_version")).foreach(
- releaseVersion => formatter.
- setReleaseVersion(MetadataVersion.fromVersionString(releaseVersion)))
+
+ def metadataVersionsToString(first: MetadataVersion, last: MetadataVersion): String = {
+ val versions = MetadataVersion.VERSIONS.slice(first.ordinal, last.ordinal + 1)
+ versions.map(_.toString).mkString(", ")
+ }
+ Option(namespace.getString("release_version")).foreach(releaseVersion => {
+ try {
+ formatter.setReleaseVersion(MetadataVersion.fromVersionString(releaseVersion))
+ } catch {
+ case _: Throwable =>
+ throw new TerseFailure(s"Unknown metadata.version $releaseVersion. Supported metadata.version are " +
+ s"${metadataVersionsToString(MetadataVersion.MINIMUM_VERSION, MetadataVersion.latestProduction())}")
Review Comment:
`KafkaConfig.unstableFeatureVersionsEnabled` resides in the core module and is inaccessible to the tool module. Additionally, since `UNSTABLE_FEATURE_VERSIONS_ENABLE_CONFIG` is an internal configuration, it cannot be retrieved by the `describeConfigs` API. Consequently, `FeatureCommand` is unable to access the value of the configuration `unstable.feature.versions.enable`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19509: Improve error message when release version is wrong [kafka]
Posted by "Yunyung (via GitHub)" <gi...@apache.org>.
Yunyung commented on PR #20185:
URL: https://github.com/apache/kafka/pull/20185#issuecomment-3083606051
Can we test if the error message doesn't include an unreleased metadata version, or whether it contains the MINIMUM_VERSION and LATEST_PRODUCTION version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19509: Improve error message when release version is wrong [kafka]
Posted by "junrao (via GitHub)" <gi...@apache.org>.
junrao commented on code in PR #20185:
URL: https://github.com/apache/kafka/pull/20185#discussion_r2226282647
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -128,9 +128,21 @@ object StorageTool extends Logging {
setIgnoreFormatted(namespace.getBoolean("ignore_formatted")).
setControllerListenerName(config.controllerListenerNames.get(0)).
setMetadataLogDirectory(config.metadataLogDir)
- Option(namespace.getString("release_version")).foreach(
- releaseVersion => formatter.
- setReleaseVersion(MetadataVersion.fromVersionString(releaseVersion)))
+
+ def metadataVersionsToString(first: MetadataVersion, last: MetadataVersion): String = {
+ val versions = MetadataVersion.VERSIONS.slice(first.ordinal, last.ordinal + 1)
+ versions.map(_.toString).mkString(", ")
+ }
+ Option(namespace.getString("release_version")).foreach(releaseVersion => {
+ try {
+ formatter.setReleaseVersion(MetadataVersion.fromVersionString(releaseVersion))
+ } catch {
+ case _: Throwable =>
+ throw new TerseFailure(s"Unknown metadata.version $releaseVersion. Supported metadata.version are " +
+ s"${metadataVersionsToString(MetadataVersion.MINIMUM_VERSION, MetadataVersion.latestProduction())}")
Review Comment:
Yes, if we improve `MetadataVersion.fromVersionString()`, we could fix the inconsistent error message in all tools and the server responses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19509: Improve error message when release version is wrong [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #20185:
URL: https://github.com/apache/kafka/pull/20185#discussion_r2227462480
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -128,9 +128,21 @@ object StorageTool extends Logging {
setIgnoreFormatted(namespace.getBoolean("ignore_formatted")).
setControllerListenerName(config.controllerListenerNames.get(0)).
setMetadataLogDirectory(config.metadataLogDir)
- Option(namespace.getString("release_version")).foreach(
- releaseVersion => formatter.
- setReleaseVersion(MetadataVersion.fromVersionString(releaseVersion)))
+
+ def metadataVersionsToString(first: MetadataVersion, last: MetadataVersion): String = {
+ val versions = MetadataVersion.VERSIONS.slice(first.ordinal, last.ordinal + 1)
+ versions.map(_.toString).mkString(", ")
+ }
+ Option(namespace.getString("release_version")).foreach(releaseVersion => {
+ try {
+ formatter.setReleaseVersion(MetadataVersion.fromVersionString(releaseVersion))
+ } catch {
+ case _: Throwable =>
+ throw new TerseFailure(s"Unknown metadata.version $releaseVersion. Supported metadata.version are " +
+ s"${metadataVersionsToString(MetadataVersion.MINIMUM_VERSION, MetadataVersion.latestProduction())}")
Review Comment:
umm, `TerseFailure` is in core module, which can't be accessed by tool module. Also, `StorageTool` is still in core module, so `StorageTool` and `FeatureCommand` can't share the same `terse` exception for now. I guess another simple solution is they could just reuse the exception message thrown by `fromVersionString` :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19509: Improve error message when release version is wrong [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #20185:
URL: https://github.com/apache/kafka/pull/20185#discussion_r2227425142
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -128,9 +128,21 @@ object StorageTool extends Logging {
setIgnoreFormatted(namespace.getBoolean("ignore_formatted")).
setControllerListenerName(config.controllerListenerNames.get(0)).
setMetadataLogDirectory(config.metadataLogDir)
- Option(namespace.getString("release_version")).foreach(
- releaseVersion => formatter.
- setReleaseVersion(MetadataVersion.fromVersionString(releaseVersion)))
+
+ def metadataVersionsToString(first: MetadataVersion, last: MetadataVersion): String = {
+ val versions = MetadataVersion.VERSIONS.slice(first.ordinal, last.ordinal + 1)
+ versions.map(_.toString).mkString(", ")
+ }
+ Option(namespace.getString("release_version")).foreach(releaseVersion => {
+ try {
+ formatter.setReleaseVersion(MetadataVersion.fromVersionString(releaseVersion))
+ } catch {
+ case _: Throwable =>
+ throw new TerseFailure(s"Unknown metadata.version $releaseVersion. Supported metadata.version are " +
+ s"${metadataVersionsToString(MetadataVersion.MINIMUM_VERSION, MetadataVersion.latestProduction())}")
Review Comment:
It would be cool if `FeatureCommand` and `StorageTool` could leverage the exception from `fromVersionString`. After fixing KAFKA-19545, the `MetadataVersion.fromVersionString` will be used only by tools only, so it could throw `TerseFailure` instead of `IllegalArgumentException`, which could then be directly reused by tools.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19509: Improve error message when release version is wrong [kafka]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky commented on code in PR #20185:
URL: https://github.com/apache/kafka/pull/20185#discussion_r2212043512
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -128,9 +128,22 @@ object StorageTool extends Logging {
setIgnoreFormatted(namespace.getBoolean("ignore_formatted")).
setControllerListenerName(config.controllerListenerNames.get(0)).
setMetadataLogDirectory(config.metadataLogDir)
- Option(namespace.getString("release_version")).foreach(
- releaseVersion => formatter.
- setReleaseVersion(MetadataVersion.fromVersionString(releaseVersion)))
+
+ def metadataVersionsToString(first: MetadataVersion, last: MetadataVersion): String = {
+ val versions = MetadataVersion.VERSIONS.slice(first.ordinal, last.ordinal + 1)
+ versions.map(_.toString).mkString(", ")
+ }
+ Option(namespace.getString("release_version")).foreach(releaseVersion => {
+ try {
+ formatter.setReleaseVersion(MetadataVersion.fromVersionString(releaseVersion))
+ } catch {
+ case _: Throwable =>
+ throw new TerseFailure("Unknown metadata.version " + releaseVersion +
+ ". Supported metadata.version are " + metadataVersionsToString(
+ MetadataVersion.MINIMUM_VERSION, MetadataVersion.latestProduction()))
+ }
Review Comment:
Could we use an interpolated string here?
```suggestion
throw new TerseFailure(s"Unknown metadata.version $releaseVersion. Supported metadata.version are ${
metadataVersionsToString(
MetadataVersion.MINIMUM_VERSION, MetadataVersion.latestProduction())
}")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19509: Improve error message when release version is wrong [kafka]
Posted by "DL1231 (via GitHub)" <gi...@apache.org>.
DL1231 commented on code in PR #20185:
URL: https://github.com/apache/kafka/pull/20185#discussion_r2227061123
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -128,9 +128,21 @@ object StorageTool extends Logging {
setIgnoreFormatted(namespace.getBoolean("ignore_formatted")).
setControllerListenerName(config.controllerListenerNames.get(0)).
setMetadataLogDirectory(config.metadataLogDir)
- Option(namespace.getString("release_version")).foreach(
- releaseVersion => formatter.
- setReleaseVersion(MetadataVersion.fromVersionString(releaseVersion)))
+
+ def metadataVersionsToString(first: MetadataVersion, last: MetadataVersion): String = {
+ val versions = MetadataVersion.VERSIONS.slice(first.ordinal, last.ordinal + 1)
+ versions.map(_.toString).mkString(", ")
+ }
+ Option(namespace.getString("release_version")).foreach(releaseVersion => {
+ try {
+ formatter.setReleaseVersion(MetadataVersion.fromVersionString(releaseVersion))
+ } catch {
+ case _: Throwable =>
+ throw new TerseFailure(s"Unknown metadata.version $releaseVersion. Supported metadata.version are " +
+ s"${metadataVersionsToString(MetadataVersion.MINIMUM_VERSION, MetadataVersion.latestProduction())}")
Review Comment:
Filed [KAFKA-19544](https://issues.apache.org/jira/browse/KAFKA-19544) to track this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19509: Improve error message when release version is wrong [kafka]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky commented on PR #20185:
URL: https://github.com/apache/kafka/pull/20185#issuecomment-3086595605
The failed test is not related to this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org