[jira] [Commented] (OAK-7864) Recording read operations to the segment store

["Francesco Mari (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16671397#comment-16671397 ] 

Francesco Mari commented on OAK-7864:
-------------------------------------

[~ahanikel], the patch looks good to me and I'm going to commit that. After that's done, I'm going to move the {{LoggingHook}} into the {{o.a.j.o.segment}} package and make it package-private. I will move the utility method {{urlEncode}} out of {{LoggingHool}} and somewhere in {{o.a.j.o.segment.util}}. These are minor issues, I will take care of them myself. Thanks for the contribution!

> Recording read operations to the segment store
> ----------------------------------------------
>
>                 Key: OAK-7864
>                 URL: https://issues.apache.org/jira/browse/OAK-7864
>             Project: Jackrabbit Oak
>          Issue Type: New Feature
>          Components: segment-tar
>    Affects Versions: 1.9.9
>            Reporter: Axel Hanikel
>            Assignee: Francesco Mari
>            Priority: Minor
>         Attachments: 0001-OAK-7864-Recording-read-operations-to-the-segment-st.patch, 0001-OAK-7864-Recording-read-operations-to-the-segment-st.patch, 0001-OAK-7864-Recording-read-operations-to-the-segment-st.patch
>
>
> This is the companion to OAK-7849. Its aim is to record read operations in a log file, like this:
> {noformat}
> 1540373238486 FelixStartLevel n? /:clusterConfig
> 1540373238497 FelixStartLevel n? /:clusterConfig
> 1540373238540 FelixStartLevel p? /:clusterConfig :clusterId
> 1540373238542 FelixStartLevel n? /:clusterConfig
> 1540373238551 FelixStartLevel p? /:clusterConfig :clusterId
> 1540373238560 FelixStartLevel n? /:clusterConfig
> 1540373238569 FelixStartLevel p? /:clusterConfig :clusterId
> 1540373243447 Apache+Sling+Repository+Startup+Thread n? /jcr:system
> 1540373243447 Apache+Sling+Repository+Startup+Thread n? /jcr:system/jcr:nodeTypes
> 1540373243447 Apache+Sling+Repository+Startup+Thread n? /jcr:system/jcr:nodeTypes/fd:xdp
> 1540373243541 Apache+Sling+Repository+Startup+Thread n? /jcr:system
> 1540373243541 Apache+Sling+Repository+Startup+Thread n? /jcr:system/jcr:nodeTypes
> 1540373243541 Apache+Sling+Repository+Startup+Thread n? /jcr:system/jcr:nodeTypes/sling:OsgiConfig
> 1540373243619 Apache+Sling+Repository+Startup+Thread n? /jcr:system
> 1540373243619 Apache+Sling+Repository+Startup+Thread n? /jcr:system/jcr:nodeTypes
> 1540373243619 Apache+Sling+Repository+Startup+Thread n? /jcr:system/jcr:nodeTypes/sling:HierarchyNode
> 1540373243619 Apache+Sling+Repository+Startup+Thread n? /jcr:system
> 1540373243619 Apache+Sling+Repository+Startup+Thread n? /jcr:system/jcr:nodeTypes
> 1540373243619 Apache+Sling+Repository+Startup+Thread n? /jcr:system/jcr:nodeTypes/sling:Folder
> 1540373243619 Apache+Sling+Repository+Startup+Thread n? /jcr:system
> 1540373243619 Apache+Sling+Repository+Startup+Thread n? /jcr:system/jcr:nodeTypes
> 1540373243619 Apache+Sling+Repository+Startup+Thread n? /jcr:system/jcr:nodeTypes/sling:OrderedFolder
> 1540373243619 Apache+Sling+Repository+Startup+Thread n? /jcr:system
> 1540373243619 Apache+Sling+Repository+Startup+Thread n? /jcr:system/rep:namespaces
> 1540373243619 Apache+Sling+Repository+Startup+Thread n? /jcr:system/rep:namespaces/rep:nsdata
> 1540373243634 Apache+Sling+Repository+Startup+Thread p? /jcr:system/rep:namespaces sling
> {noformat}
>  
> where n = node, p = property and '?' stands for "read" (so that the output can be combined with the log from OAK-7849, if desired).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)