You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/18 06:03:56 UTC

[GitHub] [airflow] pingzh opened a new pull request #7199: [AIRFLOW-6588] write_stdout and json_format are boolean

pingzh opened a new pull request #7199: [AIRFLOW-6588] write_stdout and json_format are boolean
URL: https://github.com/apache/airflow/pull/7199
 
 
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] KevinYang21 merged pull request #7199: [AIRFLOW-6588] write_stdout and json_format are boolean

Posted by GitBox <gi...@apache.org>.
KevinYang21 merged pull request #7199: [AIRFLOW-6588] write_stdout and json_format are boolean
URL: https://github.com/apache/airflow/pull/7199
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #7199: [AIRFLOW-6588] write_stdout and json_format are boolean

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7199: [AIRFLOW-6588] write_stdout and json_format are boolean
URL: https://github.com/apache/airflow/pull/7199#issuecomment-575939787
 
 
   Some static checks are failing :(

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7199: [AIRFLOW-6588] write_stdout and json_format are boolean

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7199: [AIRFLOW-6588] write_stdout and json_format are boolean
URL: https://github.com/apache/airflow/pull/7199#issuecomment-576473020
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7199?src=pr&el=h1) Report
   > Merging [#7199](https://codecov.io/gh/apache/airflow/pull/7199?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5abce471e0690c6b8d06ca25685b0845c5fd270f?src=pr&el=desc) will **decrease** coverage by `0.17%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7199/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7199?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7199      +/-   ##
   ==========================================
   - Coverage   85.41%   85.23%   -0.18%     
   ==========================================
     Files         753      758       +5     
     Lines       39685    39932     +247     
   ==========================================
   + Hits        33898    34038     +140     
   - Misses       5787     5894     +107
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7199?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/config\_templates/airflow\_local\_settings.py](https://codecov.io/gh/apache/airflow/pull/7199/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWdfdGVtcGxhdGVzL2FpcmZsb3dfbG9jYWxfc2V0dGluZ3MucHk=) | `71.73% <0%> (ø)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7199/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7199/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7199/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7199/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7199/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `76.47% <0%> (-21.18%)` | :arrow_down: |
   | [airflow/providers/amazon/aws/sensors/emr\_base.py](https://codecov.io/gh/apache/airflow/pull/7199/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9zZW5zb3JzL2Vtcl9iYXNlLnB5) | `91.66% <0%> (-8.34%)` | :arrow_down: |
   | [airflow/api/client/local\_client.py](https://codecov.io/gh/apache/airflow/pull/7199/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvY2xpZW50L2xvY2FsX2NsaWVudC5weQ==) | `92% <0%> (-8%)` | :arrow_down: |
   | [airflow/api/client/api\_client.py](https://codecov.io/gh/apache/airflow/pull/7199/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvY2xpZW50L2FwaV9jbGllbnQucHk=) | `63.15% <0%> (-1.55%)` | :arrow_down: |
   | [airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/7199/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=) | `88.37% <0%> (-0.92%)` | :arrow_down: |
   | ... and [25 more](https://codecov.io/gh/apache/airflow/pull/7199/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7199?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7199?src=pr&el=footer). Last update [5abce47...ba35b8e](https://codecov.io/gh/apache/airflow/pull/7199?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] pingzh commented on issue #7199: [AIRFLOW-6588] write_stdout and json_format are boolean

Posted by GitBox <gi...@apache.org>.
pingzh commented on issue #7199: [AIRFLOW-6588] write_stdout and json_format are boolean
URL: https://github.com/apache/airflow/pull/7199#issuecomment-576452591
 
 
   Updated

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #7199: [AIRFLOW-6588] write_stdout and json_format are boolean

Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7199: [AIRFLOW-6588] write_stdout and json_format are boolean
URL: https://github.com/apache/airflow/pull/7199#issuecomment-576330913
 
 
   You will have to update the following line too:
   
   https://github.com/apache/airflow/blob/5b44c0fc4ac0030c78ab6ad4e658e9abdf60dc04/airflow/config_templates/airflow_local_settings.py#L207

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services