You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Todd Lipcon <to...@cloudera.com> on 2010/09/10 09:03:38 UTC
Review Request: Refactor CLI parsing out of HRegionServer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/812/
-----------------------------------------------------------
Review request for hbase, stack and Jonathan Gray.
Summary
-------
Same as HBASE-2977 but from the master side
This addresses bug HBASE-2980.
http://issues.apache.org/jira/browse/HBASE-2980
Diffs
-----
src/main/java/org/apache/hadoop/hbase/master/HMaster.java adc6292
src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java 6421808
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1e046f9
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServerCommandLine.java PRE-CREATION
src/test/java/org/apache/hadoop/hbase/master/OOMEHMaster.java b51e6ab
src/test/java/org/apache/hadoop/hbase/regionserver/OOMERegionServer.java c591632
Diff: http://review.cloudera.org/r/812/diff
Testing
-------
Started a region server, also checked usage info for a bad param.
Thanks,
Todd
Re: Review Request: Refactor CLI parsing out of HRegionServer
Posted by st...@duboce.net.
> On 2010-09-10 08:42:41, stack wrote:
> > src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java, line 48
> > <http://review.cloudera.org/r/812/diff/1/?file=11389#file11389line48>
> >
> > Daemon is a good name but maybe use the not so good 'ServerCommandLine' so it aligns w/ the new Server Interface we extracted from Master and RS
> >
> > Or we could change the 'Server' Interface name to Daemon?
>
> Todd Lipcon wrote:
> Will change to ServerCommandLine like you suggested. Want to re-review the change or shall I just commit when fixed?
Just commit. No need of re-review. Thanks Todd.
- stack
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/812/#review1151
-----------------------------------------------------------
On 2010-09-13 11:29:19, Todd Lipcon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/812/
> -----------------------------------------------------------
>
> (Updated 2010-09-13 11:29:19)
>
>
> Review request for hbase, stack and Jonathan Gray.
>
>
> Summary
> -------
>
> Same as HBASE-2977 but from the master side
>
>
> This addresses bug HBASE-2980.
> http://issues.apache.org/jira/browse/HBASE-2980
>
>
> Diffs
> -----
>
> src/main/java/org/apache/hadoop/hbase/master/HMaster.java 792fb3e
> src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java 6421808
> src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1e046f9
> src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServerCommandLine.java PRE-CREATION
> src/main/java/org/apache/hadoop/hbase/util/ServerCommandLine.java PRE-CREATION
> src/test/java/org/apache/hadoop/hbase/master/OOMEHMaster.java b51e6ab
> src/test/java/org/apache/hadoop/hbase/regionserver/OOMERegionServer.java c591632
>
> Diff: http://review.cloudera.org/r/812/diff
>
>
> Testing
> -------
>
> Started a region server, also checked usage info for a bad param.
>
>
> Thanks,
>
> Todd
>
>
Re: Review Request: Refactor CLI parsing out of HRegionServer
Posted by Todd Lipcon <to...@cloudera.com>.
> On 2010-09-10 08:42:41, stack wrote:
> > src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java, line 48
> > <http://review.cloudera.org/r/812/diff/1/?file=11389#file11389line48>
> >
> > Daemon is a good name but maybe use the not so good 'ServerCommandLine' so it aligns w/ the new Server Interface we extracted from Master and RS
> >
> > Or we could change the 'Server' Interface name to Daemon?
Will change to ServerCommandLine like you suggested. Want to re-review the change or shall I just commit when fixed?
- Todd
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/812/#review1151
-----------------------------------------------------------
On 2010-09-10 00:03:38, Todd Lipcon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/812/
> -----------------------------------------------------------
>
> (Updated 2010-09-10 00:03:38)
>
>
> Review request for hbase, stack and Jonathan Gray.
>
>
> Summary
> -------
>
> Same as HBASE-2977 but from the master side
>
>
> This addresses bug HBASE-2980.
> http://issues.apache.org/jira/browse/HBASE-2980
>
>
> Diffs
> -----
>
> src/main/java/org/apache/hadoop/hbase/master/HMaster.java adc6292
> src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java 6421808
> src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1e046f9
> src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServerCommandLine.java PRE-CREATION
> src/test/java/org/apache/hadoop/hbase/master/OOMEHMaster.java b51e6ab
> src/test/java/org/apache/hadoop/hbase/regionserver/OOMERegionServer.java c591632
>
> Diff: http://review.cloudera.org/r/812/diff
>
>
> Testing
> -------
>
> Started a region server, also checked usage info for a bad param.
>
>
> Thanks,
>
> Todd
>
>
Re: Review Request: Refactor CLI parsing out of HRegionServer
Posted by st...@duboce.net.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/812/#review1151
-----------------------------------------------------------
Ship it!
+1
src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java
<http://review.cloudera.org/r/812/#comment3968>
Daemon is a good name but maybe use the not so good 'ServerCommandLine' so it aligns w/ the new Server Interface we extracted from Master and RS
Or we could change the 'Server' Interface name to Daemon?
- stack
On 2010-09-10 00:03:38, Todd Lipcon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/812/
> -----------------------------------------------------------
>
> (Updated 2010-09-10 00:03:38)
>
>
> Review request for hbase, stack and Jonathan Gray.
>
>
> Summary
> -------
>
> Same as HBASE-2977 but from the master side
>
>
> This addresses bug HBASE-2980.
> http://issues.apache.org/jira/browse/HBASE-2980
>
>
> Diffs
> -----
>
> src/main/java/org/apache/hadoop/hbase/master/HMaster.java adc6292
> src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java 6421808
> src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1e046f9
> src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServerCommandLine.java PRE-CREATION
> src/test/java/org/apache/hadoop/hbase/master/OOMEHMaster.java b51e6ab
> src/test/java/org/apache/hadoop/hbase/regionserver/OOMERegionServer.java c591632
>
> Diff: http://review.cloudera.org/r/812/diff
>
>
> Testing
> -------
>
> Started a region server, also checked usage info for a bad param.
>
>
> Thanks,
>
> Todd
>
>
Re: Review Request: Refactor CLI parsing out of HRegionServer
Posted by st...@duboce.net.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/812/#review1165
-----------------------------------------------------------
Ship it!
+1 I took a look at ServerCommandLine. Looks fine.
- stack
On 2010-09-13 11:29:19, Todd Lipcon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/812/
> -----------------------------------------------------------
>
> (Updated 2010-09-13 11:29:19)
>
>
> Review request for hbase, stack and Jonathan Gray.
>
>
> Summary
> -------
>
> Same as HBASE-2977 but from the master side
>
>
> This addresses bug HBASE-2980.
> http://issues.apache.org/jira/browse/HBASE-2980
>
>
> Diffs
> -----
>
> src/main/java/org/apache/hadoop/hbase/master/HMaster.java 792fb3e
> src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java 6421808
> src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1e046f9
> src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServerCommandLine.java PRE-CREATION
> src/main/java/org/apache/hadoop/hbase/util/ServerCommandLine.java PRE-CREATION
> src/test/java/org/apache/hadoop/hbase/master/OOMEHMaster.java b51e6ab
> src/test/java/org/apache/hadoop/hbase/regionserver/OOMERegionServer.java c591632
>
> Diff: http://review.cloudera.org/r/812/diff
>
>
> Testing
> -------
>
> Started a region server, also checked usage info for a bad param.
>
>
> Thanks,
>
> Todd
>
>
Re: Review Request: Refactor CLI parsing out of HRegionServer
Posted by Todd Lipcon <to...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/812/
-----------------------------------------------------------
(Updated 2010-09-13 11:29:19.499500)
Review request for hbase, stack and Jonathan Gray.
Changes
-------
Updated diff, renames DaemonCommandLine to ServerCommandLine. Also I realized I forgot to include DaemonCommandLine in the diff last time, so should probably have someone look that over.
Summary
-------
Same as HBASE-2977 but from the master side
This addresses bug HBASE-2980.
http://issues.apache.org/jira/browse/HBASE-2980
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/master/HMaster.java 792fb3e
src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java 6421808
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1e046f9
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServerCommandLine.java PRE-CREATION
src/main/java/org/apache/hadoop/hbase/util/ServerCommandLine.java PRE-CREATION
src/test/java/org/apache/hadoop/hbase/master/OOMEHMaster.java b51e6ab
src/test/java/org/apache/hadoop/hbase/regionserver/OOMERegionServer.java c591632
Diff: http://review.cloudera.org/r/812/diff
Testing
-------
Started a region server, also checked usage info for a bad param.
Thanks,
Todd