You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/23 21:03:08 UTC

[GitHub] [incubator-superset] pkdotson opened a new pull request #10416: feat(checkbox): update checkbox to sip-34m design

pkdotson opened a new pull request #10416:
URL: https://github.com/apache/incubator-superset/pull/10416


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   **before** 
   
   <img width="666" alt="IGNORE NULL LOCATIONS" src="https://user-images.githubusercontent.com/17326228/88338322-0a479400-cced-11ea-89e8-be00626b65b8.png">
   <img width="646" alt="IGNORE NULL LOCATIONS" src="https://user-images.githubusercontent.com/17326228/88338333-0f0c4800-cced-11ea-9ec8-9178ae286c52.png">
   
   **after**
   
   <img width="848" alt="_ IGNORE NULL LOCATIONS" src="https://user-images.githubusercontent.com/17326228/88338388-22b7ae80-cced-11ea-97ef-94ff396c9ddd.png">
   <img width="805" alt="IGNORE NULL LOCATIONS" src="https://user-images.githubusercontent.com/17326228/88338405-26e3cc00-cced-11ea-9937-7813efb87a9e.png">
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10416: style(checkbox): update checkbox to sip-34 design

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #10416:
URL: https://github.com/apache/incubator-superset/pull/10416#discussion_r459858629



##########
File path: superset-frontend/src/components/Checkbox.jsx
##########
@@ -32,15 +32,17 @@ export default function Checkbox({ checked, onChange, style }) {
         role="button"
         tabIndex={0}
         className={`fa fa-check ${
-          checked ? 'text-primary' : 'text-transparent'
+          checked ? 'text-white' : 'text-transparent'
         }`}
         onClick={() => {
           onChange(!checked);
         }}
         style={{
-          border: '1px solid #aaa',
+          border: `${checked ? '1px solid #20A7C9' : '1px solid #aaa'}`,
           borderRadius: '2px',
           cursor: 'pointer',
+          boxShaddow: 'inset 1px 0px 0px #E0E0E0',
+          backgroundColor: `${checked ? '#20A7C9' : 'transparent'}` 

Review comment:
       Also let's never use hardcoded colors!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] pkdotson commented on a change in pull request #10416: feat(checkbox): update checkbox to sip-34 design

Posted by GitBox <gi...@apache.org>.
pkdotson commented on a change in pull request #10416:
URL: https://github.com/apache/incubator-superset/pull/10416#discussion_r459739364



##########
File path: superset-frontend/src/components/Checkbox.jsx
##########
@@ -32,15 +32,17 @@ export default function Checkbox({ checked, onChange, style }) {
         role="button"
         tabIndex={0}
         className={`fa fa-check ${
-          checked ? 'text-primary' : 'text-transparent'
+          checked ? 'text-white' : 'text-transparent'
         }`}
         onClick={() => {
           onChange(!checked);
         }}
         style={{
-          border: '1px solid #aaa',
+          border: `${checked ? '1px solid #20A7C9' : '1px solid #aaa'}`,
           borderRadius: '2px',
           cursor: 'pointer',
+          boxShaddow: 'inset 1px 0px 0px #E0E0E0',
+          backgroundColor: `${checked ? '#20A7C9' : 'transparent'}` 

Review comment:
       sounds like a good idea to me. @rusackas any thoughts on this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10416: style(checkbox): update checkbox to sip-34 design

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10416:
URL: https://github.com/apache/incubator-superset/pull/10416#issuecomment-667309038


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10416?src=pr&el=h1) Report
   > Merging [#10416](https://codecov.io/gh/apache/incubator-superset/pull/10416?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7a329c25e9867636fd8a79c3f19b45186bd0f95a&el=desc) will **increase** coverage by `1.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10416/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10416?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10416      +/-   ##
   ==========================================
   + Coverage   70.80%   71.83%   +1.02%     
   ==========================================
     Files         604      196     -408     
     Lines       32426    21027   -11399     
     Branches     3414        0    -3414     
   ==========================================
   - Hits        22960    15104    -7856     
   + Misses       9354     5923    -3431     
   + Partials      112        0     -112     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `71.83% <ø> (+1.44%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10416?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `67.76% <0.00%> (-1.63%)` | :arrow_down: |
   | [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `54.23% <0.00%> (-1.58%)` | :arrow_down: |
   | [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `83.33% <0.00%> (-1.12%)` | :arrow_down: |
   | [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `83.82% <0.00%> (-0.84%)` | :arrow_down: |
   | [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | `60.00% <0.00%> (-0.72%)` | :arrow_down: |
   | [superset/tasks/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `73.52% <0.00%> (-0.39%)` | :arrow_down: |
   | [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `83.85% <0.00%> (-0.28%)` | :arrow_down: |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/commands/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvdXRpbHMucHk=) | `100.00% <0.00%> (ø)` | |
   | [superset/utils/import\_datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvaW1wb3J0X2RhdGFzb3VyY2UucHk=) | `100.00% <0.00%> (ø)` | |
   | ... and [415 more](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10416?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10416?src=pr&el=footer). Last update [7a329c2...4f9fe56](https://codecov.io/gh/apache/incubator-superset/pull/10416?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10416: style(checkbox): update checkbox to sip-34 design

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10416:
URL: https://github.com/apache/incubator-superset/pull/10416#issuecomment-667309038


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10416?src=pr&el=h1) Report
   > Merging [#10416](https://codecov.io/gh/apache/incubator-superset/pull/10416?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7a329c25e9867636fd8a79c3f19b45186bd0f95a&el=desc) will **increase** coverage by `1.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10416/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10416?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10416      +/-   ##
   ==========================================
   + Coverage   70.80%   71.84%   +1.03%     
   ==========================================
     Files         604      196     -408     
     Lines       32426    21018   -11408     
     Branches     3414        0    -3414     
   ==========================================
   - Hits        22960    15100    -7860     
   + Misses       9354     5918    -3436     
   + Partials      112        0     -112     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `71.84% <ø> (+1.45%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10416?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `67.76% <0.00%> (-1.63%)` | :arrow_down: |
   | [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `54.23% <0.00%> (-1.58%)` | :arrow_down: |
   | [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `83.33% <0.00%> (-1.12%)` | :arrow_down: |
   | [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `83.82% <0.00%> (-0.84%)` | :arrow_down: |
   | [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | `60.00% <0.00%> (-0.72%)` | :arrow_down: |
   | [superset/tasks/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `73.52% <0.00%> (-0.39%)` | :arrow_down: |
   | [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `83.85% <0.00%> (-0.28%)` | :arrow_down: |
   | [superset/commands/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvdXRpbHMucHk=) | `100.00% <0.00%> (ø)` | |
   | [superset/utils/import\_datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvaW1wb3J0X2RhdGFzb3VyY2UucHk=) | `100.00% <0.00%> (ø)` | |
   | [...hboard/components/gridComponents/new/NewColumn.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdDb2x1bW4uanN4) | | |
   | ... and [412 more](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10416?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10416?src=pr&el=footer). Last update [7a329c2...4f9fe56](https://codecov.io/gh/apache/incubator-superset/pull/10416?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10416: style(checkbox): update checkbox to sip-34 design

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10416:
URL: https://github.com/apache/incubator-superset/pull/10416#issuecomment-667309038


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10416?src=pr&el=h1) Report
   > Merging [#10416](https://codecov.io/gh/apache/incubator-superset/pull/10416?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7a329c25e9867636fd8a79c3f19b45186bd0f95a&el=desc) will **increase** coverage by `1.04%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10416/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10416?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10416      +/-   ##
   ==========================================
   + Coverage   70.80%   71.85%   +1.04%     
   ==========================================
     Files         604      196     -408     
     Lines       32426    21018   -11408     
     Branches     3414        0    -3414     
   ==========================================
   - Hits        22960    15102    -7858     
   + Misses       9354     5916    -3438     
   + Partials      112        0     -112     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `71.85% <ø> (+1.46%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10416?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `67.76% <0.00%> (-1.63%)` | :arrow_down: |
   | [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `54.23% <0.00%> (-1.58%)` | :arrow_down: |
   | [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `83.33% <0.00%> (-1.12%)` | :arrow_down: |
   | [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `83.82% <0.00%> (-0.84%)` | :arrow_down: |
   | [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | `60.00% <0.00%> (-0.72%)` | :arrow_down: |
   | [superset/tasks/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `73.52% <0.00%> (-0.39%)` | :arrow_down: |
   | [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `83.85% <0.00%> (-0.28%)` | :arrow_down: |
   | [superset/commands/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvdXRpbHMucHk=) | `100.00% <0.00%> (ø)` | |
   | [superset/utils/import\_datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvaW1wb3J0X2RhdGFzb3VyY2UucHk=) | `100.00% <0.00%> (ø)` | |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | | |
   | ... and [412 more](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10416?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10416?src=pr&el=footer). Last update [7a329c2...4f9fe56](https://codecov.io/gh/apache/incubator-superset/pull/10416?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on pull request #10416: style(checkbox): update checkbox to sip-34 design

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #10416:
URL: https://github.com/apache/incubator-superset/pull/10416#issuecomment-663353621


   Oh - side note - I noticed some rogue checkboxes in the "Filter Scope Modal" today that use a hard coded older theme color.
   <img width="1041" alt="Screen Shot 2020-07-23 at 10 27 43 PM" src="https://user-images.githubusercontent.com/487433/88363117-ccba2980-cd33-11ea-9763-55a5d952b263.png">
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai commented on a change in pull request #10416: feat(checkbox): update checkbox to sip-34 design

Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #10416:
URL: https://github.com/apache/incubator-superset/pull/10416#discussion_r459731645



##########
File path: superset-frontend/src/components/Checkbox.jsx
##########
@@ -32,15 +32,17 @@ export default function Checkbox({ checked, onChange, style }) {
         role="button"
         tabIndex={0}
         className={`fa fa-check ${
-          checked ? 'text-primary' : 'text-transparent'
+          checked ? 'text-white' : 'text-transparent'
         }`}
         onClick={() => {
           onChange(!checked);
         }}
         style={{
-          border: '1px solid #aaa',
+          border: `${checked ? '1px solid #20A7C9' : '1px solid #aaa'}`,
           borderRadius: '2px',
           cursor: 'pointer',
+          boxShaddow: 'inset 1px 0px 0px #E0E0E0',
+          backgroundColor: `${checked ? '#20A7C9' : 'transparent'}` 

Review comment:
       I didn't realize this component exists. Thoughts on deprecating this in favor of https://github.com/preset-io/incubator-superset/blob/master/superset-frontend/src/components/IndeterminateCheckbox.tsx which is using the new Icon component and emotion styles?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on a change in pull request #10416: style(checkbox): update checkbox to sip-34 design

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10416:
URL: https://github.com/apache/incubator-superset/pull/10416#discussion_r459759626



##########
File path: superset-frontend/src/components/Checkbox.jsx
##########
@@ -32,15 +32,17 @@ export default function Checkbox({ checked, onChange, style }) {
         role="button"
         tabIndex={0}
         className={`fa fa-check ${
-          checked ? 'text-primary' : 'text-transparent'
+          checked ? 'text-white' : 'text-transparent'
         }`}
         onClick={() => {
           onChange(!checked);
         }}
         style={{
-          border: '1px solid #aaa',
+          border: `${checked ? '1px solid #20A7C9' : '1px solid #aaa'}`,
           borderRadius: '2px',
           cursor: 'pointer',
+          boxShaddow: 'inset 1px 0px 0px #E0E0E0',
+          backgroundColor: `${checked ? '#20A7C9' : 'transparent'}` 

Review comment:
       I'm all for consolidation! Use our Checkbox wherever checkboxes are used!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] pkdotson closed pull request #10416: style(checkbox): update checkbox to sip-34 design

Posted by GitBox <gi...@apache.org>.
pkdotson closed pull request #10416:
URL: https://github.com/apache/incubator-superset/pull/10416


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] stale[bot] commented on pull request #10416: style(checkbox): update checkbox to sip-34 design

Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #10416:
URL: https://github.com/apache/incubator-superset/pull/10416#issuecomment-703188908


   This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10416: style(checkbox): update checkbox to sip-34 design

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10416:
URL: https://github.com/apache/incubator-superset/pull/10416#issuecomment-667309038


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10416?src=pr&el=h1) Report
   > Merging [#10416](https://codecov.io/gh/apache/incubator-superset/pull/10416?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7a329c25e9867636fd8a79c3f19b45186bd0f95a&el=desc) will **increase** coverage by `1.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10416/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10416?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10416      +/-   ##
   ==========================================
   + Coverage   70.80%   71.84%   +1.03%     
   ==========================================
     Files         604      196     -408     
     Lines       32426    21018   -11408     
     Branches     3414        0    -3414     
   ==========================================
   - Hits        22960    15100    -7860     
   + Misses       9354     5918    -3436     
   + Partials      112        0     -112     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `71.84% <ø> (+1.45%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10416?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `67.76% <0.00%> (-1.63%)` | :arrow_down: |
   | [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `54.23% <0.00%> (-1.58%)` | :arrow_down: |
   | [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `83.33% <0.00%> (-1.12%)` | :arrow_down: |
   | [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `83.82% <0.00%> (-0.84%)` | :arrow_down: |
   | [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | `60.00% <0.00%> (-0.72%)` | :arrow_down: |
   | [superset/tasks/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `73.52% <0.00%> (-0.39%)` | :arrow_down: |
   | [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `83.85% <0.00%> (-0.28%)` | :arrow_down: |
   | [superset/commands/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvdXRpbHMucHk=) | `100.00% <0.00%> (ø)` | |
   | [superset/utils/import\_datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvaW1wb3J0X2RhdGFzb3VyY2UucHk=) | `100.00% <0.00%> (ø)` | |
   | [...et-frontend/src/dashboard/components/CodeModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0NvZGVNb2RhbC5qc3g=) | | |
   | ... and [412 more](https://codecov.io/gh/apache/incubator-superset/pull/10416/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10416?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10416?src=pr&el=footer). Last update [7a329c2...4f9fe56](https://codecov.io/gh/apache/incubator-superset/pull/10416?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] stale[bot] closed pull request #10416: style(checkbox): update checkbox to sip-34 design

Posted by GitBox <gi...@apache.org>.
stale[bot] closed pull request #10416:
URL: https://github.com/apache/incubator-superset/pull/10416


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org