You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/17 08:59:00 UTC

[jira] [Commented] (DRILL-6421) Refactor DecimalUtility and CoreDecimalUtility classes

    [ https://issues.apache.org/jira/browse/DRILL-6421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478767#comment-16478767 ] 

ASF GitHub Bot commented on DRILL-6421:
---------------------------------------

vvysotskyi opened a new pull request #1267: DRILL-6421: Refactor DecimalUtility and CoreDecimalUtility classes
URL: https://github.com/apache/drill/pull/1267
 
 
   - Removed unused methods
   - Added javadocs for some methods
   - Removed CoreDecimalUtility class

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Refactor DecimalUtility and CoreDecimalUtility classes
> ------------------------------------------------------
>
>                 Key: DRILL-6421
>                 URL: https://issues.apache.org/jira/browse/DRILL-6421
>             Project: Apache Drill
>          Issue Type: Task
>            Reporter: Volodymyr Vysotskyi
>            Assignee: Volodymyr Vysotskyi
>            Priority: Major
>             Fix For: 1.14.0
>
>
> After the changes, made inĀ DRILL-6094, most of the methods in {{DecimalUtility}} class became unused, so they should be removed. 
> Both {{DecimalUtility}} andĀ {{CoreDecimalUtility}} are intended for the same goals, so they should be merged.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)