You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/08/15 00:21:00 UTC
[jira] [Commented] (CAMEL-12730) FindBugs warnings: Suspicious
reference comparison
[ https://issues.apache.org/jira/browse/CAMEL-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16580570#comment-16580570 ]
ASF GitHub Bot commented on CAMEL-12730:
----------------------------------------
hiroakiy opened a new pull request #2472: CAMEL-12730: Fix FindBugs warnings: Suspicious reference comparison
URL: https://github.com/apache/camel/pull/2472
FindBugs-3.0.1 ([http://findbugs.sourceforge.net/](http://findbugs.sourceforge.net/)) reported 2 RC_REF_COMPARISON warnings on master:
```
H C RC: Suspicious comparison of Integer references in org.apache.camel.processor.Throttler.calculateAndSetMaxRequestsPerPeriod(Exchange) At Throttler.java:[line 312]
H C RC: Suspicious comparison of Integer references in org.apache.camel.processor.Throttler.calculateAndSetMaxRequestsPerPeriod(DelayQueue, Exchange, Integer) At Throttler.java:[line 360]
```
The description of the bug is as follows:
> **RC: Suspicious reference comparison (RC_REF_COMPARISON)**
> This method compares two reference values using the == or != operator, where the correct way to compare instances of this type is generally with the equals() method. It is possible to create distinct instances that are equal but do not compare as == since they are different objects. Examples of classes which should generally not be compared by reference are java.lang.Integer, java.lang.Float, etc.
> [http://findbugs.sourceforge.net/bugDescriptions.html#RC_REF_COMPARISON](http://findbugs.sourceforge.net/bugDescriptions.html#RC_REF_COMPARISON)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> FindBugs warnings: Suspicious reference comparison
> --------------------------------------------------
>
> Key: CAMEL-12730
> URL: https://issues.apache.org/jira/browse/CAMEL-12730
> Project: Camel
> Issue Type: Bug
> Components: camel-core
> Reporter: Hiroaki Yoshida
> Priority: Major
>
> FindBugs-3.0.1 ([http://findbugs.sourceforge.net/]) reported 2 RC_REF_COMPARISON warnings on master:
> {code:java}
> H C RC: Suspicious comparison of Integer references in org.apache.camel.processor.Throttler.calculateAndSetMaxRequestsPerPeriod(Exchange) At Throttler.java:[line 312]
> H C RC: Suspicious comparison of Integer references in org.apache.camel.processor.Throttler.calculateAndSetMaxRequestsPerPeriod(DelayQueue, Exchange, Integer) At Throttler.java:[line 360]
> {code}
> The description of the bug is as follows:
> {quote}*RC: Suspicious reference comparison (RC_REF_COMPARISON)*
> This method compares two reference values using the == or != operator, where the correct way to compare instances of this type is generally with the equals() method. It is possible to create distinct instances that are equal but do not compare as == since they are different objects. Examples of classes which should generally not be compared by reference are java.lang.Integer, java.lang.Float, etc.
> [http://findbugs.sourceforge.net/bugDescriptions.html#RC_REF_COMPARISON]
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)