You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/25 17:12:35 UTC
[GitHub] [spark] shrutig opened a new pull request #29872: [SPARK-32996][Web-UI] Handle Option.empty v1.ExecutorSummary#peakMemoryMetrics
shrutig opened a new pull request #29872:
URL: https://github.com/apache/spark/pull/29872
### What changes were proposed in this pull request?
When `peakMemoryMetrics` in `ExecutorSummary` is `Option.empty`, then the `ExecutorMetricsJsonSerializer#serialize` method does not execute the `jsonGenerator.writeObject` method. This causes the json to be generated with `peakMemoryMetrics` key added to the serialized string, but no corresponding value.
This causes an error to be thrown when it is the next key `attributes` turn to be added to the json:
`com.fasterxml.jackson.core.JsonGenerationException: Can not write a field name, expecting a value
`
### Why are the changes needed?
At the start of the Spark job, if `peakMemoryMetrics` is `Option.empty`, then it causes
a `com.fasterxml.jackson.core.JsonGenerationException` to be thrown when we navigate to the Executors tab in Spark UI:
Complete stacktrace:
> com.fasterxml.jackson.core.JsonGenerationException: Can not write a field name, expecting a value
> at com.fasterxml.jackson.core.JsonGenerator._reportError(JsonGenerator.java:2080)
> at com.fasterxml.jackson.core.json.WriterBasedJsonGenerator.writeFieldName(WriterBasedJsonGenerator.java:161)
> at com.fasterxml.jackson.databind.ser.BeanPropertyWriter.serializeAsField(BeanPropertyWriter.java:725)
> at com.fasterxml.jackson.databind.ser.std.BeanSerializerBase.serializeFields(BeanSerializerBase.java:721)
> at com.fasterxml.jackson.databind.ser.BeanSerializer.serialize(BeanSerializer.java:166)
> at com.fasterxml.jackson.databind.ser.std.CollectionSerializer.serializeContents(CollectionSerializer.java:145)
> at com.fasterxml.jackson.module.scala.ser.IterableSerializer.serializeContents(IterableSerializerModule.scala:26)
> at com.fasterxml.jackson.module.scala.ser.IterableSerializer.serializeContents$(IterableSerializerModule.scala:25)
> at com.fasterxml.jackson.module.scala.ser.UnresolvedIterableSerializer.serializeContents(IterableSerializerModule.scala:54)
> at com.fasterxml.jackson.module.scala.ser.UnresolvedIterableSerializer.serializeContents(IterableSerializerModule.scala:54)
> at com.fasterxml.jackson.databind.ser.std.AsArraySerializerBase.serialize(AsArraySerializerBase.java:250)
> at com.fasterxml.jackson.databind.ser.DefaultSerializerProvider._serialize(DefaultSerializerProvider.java:480)
> at com.fasterxml.jackson.databind.ser.DefaultSerializerProvider.serializeValue(DefaultSerializerProvider.java:319)
> at com.fasterxml.jackson.databind.ObjectMapper._configAndWriteValue(ObjectMapper.java:4094)
> at com.fasterxml.jackson.databind.ObjectMapper.writeValueAsString(ObjectMapper.java:3404)
> at org.apache.spark.ui.exec.ExecutorsPage.allExecutorsDataScript$1(ExecutorsTab.scala:64)
> at org.apache.spark.ui.exec.ExecutorsPage.render(ExecutorsTab.scala:76)
> at org.apache.spark.ui.WebUI.$anonfun$attachPage$1(WebUI.scala:89)
> at org.apache.spark.ui.JettyUtils$$anon$1.doGet(JettyUtils.scala:80)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:687)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
> at org.sparkproject.jetty.servlet.ServletHolder.handle(ServletHolder.java:873)
> at org.sparkproject.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1623)
> at org.apache.spark.ui.HttpSecurityFilter.doFilter(HttpSecurityFilter.scala:95)
> at org.sparkproject.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1610)
> at org.sparkproject.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:540)
> at org.sparkproject.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:255)
> at org.sparkproject.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1345)
> at org.sparkproject.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:203)
> at org.sparkproject.jetty.servlet.ServletHandler.doScope(ServletHandler.java:480)
> at org.sparkproject.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:201)
> at org.sparkproject.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1247)
> at org.sparkproject.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:144)
> at org.sparkproject.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:753)
> at org.sparkproject.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:220)
> at org.sparkproject.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:132)
> at org.sparkproject.jetty.server.Server.handle(Server.java:505)
> at org.sparkproject.jetty.server.HttpChannel.handle(HttpChannel.java:370)
> at org.sparkproject.jetty.server.HttpConnection.onFillable(HttpConnection.java:267)
> at org.sparkproject.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:305)
> at org.sparkproject.jetty.io.FillInterest.fillable(FillInterest.java:103)
> at org.sparkproject.jetty.io.ChannelEndPoint$2.run(ChannelEndPoint.java:117)
> at org.sparkproject.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:333)
> at org.sparkproject.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:310)
> at org.sparkproject.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:168)
> at org.sparkproject.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:126)
> at org.sparkproject.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:366)
> at org.sparkproject.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:698)
> at org.sparkproject.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:804)
> at java.base/java.lang.Thread.run(Thread.java:834)
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Unit test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29872: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699444896
**[Test build #129131 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129131/testReport)** for PR 29872 at commit [`2967673`](https://github.com/apache/spark/commit/29676739bbb2ef6db17cd170da7fb1ed24ffa769).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29872: [SPARK-32996][Web-UI] Handle Option.empty v1.ExecutorSummary#peakMemoryMetrics
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699051979
**[Test build #129117 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129117/testReport)** for PR 29872 at commit [`fe33f7f`](https://github.com/apache/spark/commit/fe33f7f89bbc9763b14f52ff7348d4ef2da4cd06).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29872: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699197271
**[Test build #129125 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129125/testReport)** for PR 29872 at commit [`c27a699`](https://github.com/apache/spark/commit/c27a6994be6f580e331d49aeedfab2ca4c427e30).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29872: [SPARK-32996][Web-UI] Handle Option.empty v1.ExecutorSummary#peakMemoryMetrics
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699049437
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29872: [SPARK-32996][Web-UI] Handle Option.empty v1.ExecutorSummary#peakMemoryMetrics
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699052005
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129117/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29872: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699608546
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33761/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dbtsai commented on pull request #29872: [SPARK-32996][Web-UI] Handle Option.empty v1.ExecutorSummary#peakMemoryMetrics
Posted by GitBox <gi...@apache.org>.
dbtsai commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699053253
@shrutig there is a failure in compiling test code.
```
[error] /home/jenkins/workspace/SparkPullRequestBuilder@2/core/src/test/java/org/apache/spark/status/api/v1/ExecutorSummarySuite.scala:31: not enough arguments for constructor ExecutorSummary: (id: String, hostPort: String, isActive: Boolean, rddBlocks: Int, memoryUsed: Long, diskUsed: Long, totalCores: Int, maxTasks: Int, activeTasks: Int, failedTasks: Int, completedTasks: Int, totalTasks: Int, totalDuration: Long, totalGCTime: Long, totalInputBytes: Long, totalShuffleRead: Long, totalShuffleWrite: Long, isBlacklisted: Boolean, maxMemory: Long, addTime: java.util.Date, removeTime: Option[java.util.Date], removeReason: Option[String], executorLogs: Map[String,String], memoryMetrics: Option[org.apache.spark.status.api.v1.MemoryMetrics], blacklistedInStages: Set[Int], peakMemoryMetrics: Option[org.apache.spark.executor.ExecutorMetrics], attributes: Map[String,String], resources: Map[String,org.apache.spark.resource.ResourceInformation], resourceProfileId: Int)org.apache.spark.status
.api.v1.ExecutorSummary.
[error] Unspecified value parameter resourceProfileId.
[error] val executorSummary = new ExecutorSummary("id", "host:port", true, 1,
[error] ^
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29872: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699620927
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29872: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699402597
**[Test build #129131 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129131/testReport)** for PR 29872 at commit [`2967673`](https://github.com/apache/spark/commit/29676739bbb2ef6db17cd170da7fb1ed24ffa769).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #29872: [SPARK-32996][Web-UI] Handle Option.empty v1.ExecutorSummary#peakMemoryMetrics
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699048281
cc @dbtsai
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29872: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699402597
**[Test build #129131 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129131/testReport)** for PR 29872 at commit [`2967673`](https://github.com/apache/spark/commit/29676739bbb2ef6db17cd170da7fb1ed24ffa769).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29872: [SPARK-32996][Web-UI] Handle Option.empty v1.ExecutorSummary#peakMemoryMetrics
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699049437
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shrutig commented on pull request #29872: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
shrutig commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-700342212
> Shall we cherry-pick this one to branch 3.0 as well?
Yes, will do
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #29872: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-700168554
@shrutig Can you make a backport to 3.0? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29872: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699611073
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33761/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29872: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699445199
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29872: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699266831
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #29872: [SPARK-32996][Web-UI] Handle Option.empty v1.ExecutorSummary#peakMemoryMetrics
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699208384
Thanks @shrutig.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29872: [SPARK-32996][Web-UI] Handle Option.empty v1.ExecutorSummary#peakMemoryMetrics
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699049100
**[Test build #129117 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129117/testReport)** for PR 29872 at commit [`fe33f7f`](https://github.com/apache/spark/commit/fe33f7f89bbc9763b14f52ff7348d4ef2da4cd06).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shrutig commented on pull request #29872: [SPARK-32996][Web-UI] Handle Option.empty v1.ExecutorSummary#peakMemoryMetrics
Posted by GitBox <gi...@apache.org>.
shrutig commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699191435
Ack. fixing the test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29872: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699445207
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129131/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29872: [SPARK-32996][Web-UI] Handle Option.empty v1.ExecutorSummary#peakMemoryMetrics
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699197271
**[Test build #129125 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129125/testReport)** for PR 29872 at commit [`c27a699`](https://github.com/apache/spark/commit/c27a6994be6f580e331d49aeedfab2ca4c427e30).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29872: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699604063
**[Test build #129145 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129145/testReport)** for PR 29872 at commit [`2967673`](https://github.com/apache/spark/commit/29676739bbb2ef6db17cd170da7fb1ed24ffa769).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29872: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699266831
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #29872: [SPARK-32996][Web-UI] Handle Option.empty v1.ExecutorSummary#peakMemoryMetrics
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699054293
`ExecutorSummary` might have more parameter in master branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29872: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699266269
**[Test build #129125 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129125/testReport)** for PR 29872 at commit [`c27a699`](https://github.com/apache/spark/commit/c27a6994be6f580e331d49aeedfab2ca4c427e30).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29872: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699611083
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29872: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699604063
**[Test build #129145 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129145/testReport)** for PR 29872 at commit [`2967673`](https://github.com/apache/spark/commit/29676739bbb2ef6db17cd170da7fb1ed24ffa769).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29872: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699620927
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya closed pull request #29872: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
viirya closed pull request #29872:
URL: https://github.com/apache/spark/pull/29872
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #29872: [SPARK-32996][Web-UI] Handle Option.empty v1.ExecutorSummary#peakMemoryMetrics
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699048400
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #29872: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-700163977
Thanks! Merging to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #29872: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-700169168
> @shrutig @viirya sorry for the late reply.
> Shall we cherry-pick this one to branch 3.0 as well?
Yeah, we should. There is conflict in branch 3.0, so @shrutig may need to prepare a backport for branch-3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #29872: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699666213
Thanks @HyukjinKwon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dbtsai commented on pull request #29872: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
dbtsai commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-700160341
LGTM too!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29872: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699611083
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29872: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699445199
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29872: [SPARK-32996][Web-UI] Handle Option.empty v1.ExecutorSummary#peakMemoryMetrics
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699051999
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29872: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699620777
**[Test build #129145 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129145/testReport)** for PR 29872 at commit [`2967673`](https://github.com/apache/spark/commit/29676739bbb2ef6db17cd170da7fb1ed24ffa769).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29872: [SPARK-32996][Web-UI] Handle Option.empty v1.ExecutorSummary#peakMemoryMetrics
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699049100
**[Test build #129117 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129117/testReport)** for PR 29872 at commit [`fe33f7f`](https://github.com/apache/spark/commit/fe33f7f89bbc9763b14f52ff7348d4ef2da4cd06).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shrutig commented on pull request #29872: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
shrutig commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699399318
Updated PR to have `peakMemoryMetrics` revert to `None` in `ExecutorMetricsJsonDeserializer`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #29872: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-700166072
@shrutig @viirya sorry for the late reply.
Shall we cherry-pick this one to branch 3.0 as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29872: [SPARK-32996][Web-UI] Handle empty ExecutorMetrics in ExecutorMetricsJsonSerializer
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29872:
URL: https://github.com/apache/spark/pull/29872#issuecomment-699603818
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org