You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/05 15:01:26 UTC
[GitHub] [airflow] ashb opened a new pull request, #24847: Fix cycle bug with attaching label to task group
ashb opened a new pull request, #24847:
URL: https://github.com/apache/airflow/pull/24847
The problem was specific to EdgeModifiers as they try to be
"transparent" to upstream/downstream
The fix is to set track the upstream/downstream for the task group
before making any changes to the EdgeModifiers' relations -- otherwise
the roots of the TG were added as dependencies to themeslves!
Fixes #19785
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24847: Fix cycle bug with attaching label to task group
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24847:
URL: https://github.com/apache/airflow/pull/24847#issuecomment-1175201912
Did we have DCG instad of DAG for a short while :) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #24847: Fix cycle bug with attaching label to task group
Posted by GitBox <gi...@apache.org>.
ashb merged PR #24847:
URL: https://github.com/apache/airflow/pull/24847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #24847: Fix cycle bug with attaching label to task group
Posted by GitBox <gi...@apache.org>.
ashb commented on PR #24847:
URL: https://github.com/apache/airflow/pull/24847#issuecomment-1175206782
Only in this one specific edge case where you do `[Label()] >> tg` -- `Label() >> tg` was fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] rvatsastro commented on pull request #24847: Fix cycle bug with attaching label to task group
Posted by GitBox <gi...@apache.org>.
rvatsastro commented on PR #24847:
URL: https://github.com/apache/airflow/pull/24847#issuecomment-1180231790
Verified
<img width="1498" alt="image" src="https://user-images.githubusercontent.com/102275369/178245684-2e942d10-5b15-404c-8b06-18251b08a41f.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org