You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/08 05:54:48 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #37432: [SPARK-39973][CORE] Suppress error logs when the number of timers is set to 0
HyukjinKwon opened a new pull request, #37432:
URL: https://github.com/apache/spark/pull/37432
### What changes were proposed in this pull request?
This PR proposes to:
- Suppress error logs when the number of timers is set to 0.
- Add documentation for describing its behaviour clearly:
- 0: disable the feature
- -1: no limit
- Otherwise, explicit limit.
- Throw an exception if the configuration is set to the number lower than -1.
This is an internal configuration, numbers lower than -1 don't make much sense, and this configuration sort of less known. So I think it's pretty safe to do this.
### Why are the changes needed?
To avoid noisy error logs, and document the feature properly.
### Does this PR introduce _any_ user-facing change?
Yes. When `spark.scheduler.listenerbus.metrics.maxListenerClassesTimed` is set to `0`, it does not show a warning such as:
```
LiveListenerBusMetrics: Not measuring processing time for listener class org.apache.spark.sql.util.ExecutionListenerBus because a maximum of 0 listener classes are already timed.
```
### How was this patch tested?
Unittest is added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37432: [SPARK-39973][CORE] Suppress error logs when the number of timers is set to 0
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37432:
URL: https://github.com/apache/spark/pull/37432#issuecomment-1207915097
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37432: [SPARK-39973][CORE] Suppress error logs when the number of timers is set to 0
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37432:
URL: https://github.com/apache/spark/pull/37432#issuecomment-1207915509
thank you guys!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #37432: [SPARK-39973][CORE] Suppress error logs when the number of timers is set to 0
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #37432: [SPARK-39973][CORE] Suppress error logs when the number of timers is set to 0
URL: https://github.com/apache/spark/pull/37432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org